Bug 729604
| Summary: | Problem found by Coverity | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Pavel Raiskup <praiskup> |
| Component: | tog-pegasus | Assignee: | Vitezslav Crhonek <vcrhonek> |
| Status: | CLOSED NOTABUG | QA Contact: | qe-baseos-daemons |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.2 | CC: | kdudka |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-16 10:48:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
After source code inspection - it seems to be false positive. |
Found by difference scan RHEL6.1/RHEL6.2 tog-pegasus package (tog-pegasus 2.9.1/2.11.0). src/slp/slp_client/src/cmd-utils/slp_client/slp_client.cpp:1389: src/slp/slp_client/src/cmd-utils/slp_client/slp_client.cpp:1696: - should'nt there be "#ifdef PEGASUS_ENABLE_IPV6"? Because structure p_addr has two parts (not only "ip4_addr"). Inside slp_is_loop_back could occur a static overrun if "addr" was ipv6 address. - called from line 1755, 1762, 1768 and it seems on ipv6 addresses also Coverity says: Error: OVERRUN_STATIC: /builddir/build/BUILD/pegasus/src/slp/slp_client/src/cmd-utils/slp_client/slp_client.cpp:1389: overrun-buffer-val: Overrunning struct type struct in_addr of size 4 bytes by passing it as an argument to a function which indexes it at byte position 15. /builddir/build/BUILD/pegasus/src/slp/slp_client/src/cmd-utils/slp_client/slp_utils.cpp:350: access_dbuff_const: Calling "memcmp" indexes array "addr" with index "sizeof (ip6) /*16*/" at byte position 15.