Bug 730037

$ rpmlint -i -v *
perl-autovivification.i686: I: checking
perl-autovivification.i686: W: spelling-error Summary(en_US) Lexically -> Lexical, Exotically, Allergically
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.i686: W: spelling-error %description -l en_US dereferenced -> referenced, deference, reverenced
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.i686: W: spelling-error %description -l en_US dereferencing -> referencing, videoconferencing, conferencing
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.i686: I: checking-url http://search.cpan.org/dist/autovivification/ (timeout 10 seconds)
perl-autovivification.src: I: checking
perl-autovivification.src: W: spelling-error Summary(en_US) Lexically -> Lexical, Exotically, Allergically
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.src: W: spelling-error %description -l en_US dereferenced -> referenced, deference, reverenced
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.src: W: spelling-error %description -l en_US dereferencing -> referencing, videoconferencing, conferencing
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.src: I: checking-url http://search.cpan.org/dist/autovivification/ (timeout 10 seconds)
perl-autovivification.src: I: checking-url http://search.cpan.org/CPAN/authors/id/V/VP/VPIT/autovivification-0.09.tar.gz (timeout 10 seconds)
perl-autovivification.x86_64: I: checking
perl-autovivification.x86_64: W: spelling-error Summary(en_US) Lexically -> Lexical, Exotically, Allergically
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.x86_64: W: spelling-error %description -l en_US dereferenced -> referenced, deference, reverenced
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.x86_64: W: spelling-error %description -l en_US dereferencing -> referencing, videoconferencing, conferencing
The value of this tag appears to be misspelled. Please double-check.

perl-autovivification.x86_64: I: checking-url http://search.cpan.org/dist/autovivification/ (timeout 10 seconds)
perl-autovivification-debuginfo.i686: I: checking
perl-autovivification-debuginfo.i686: I: checking-url http://search.cpan.org/dist/autovivification/ (timeout 10 seconds)
perl-autovivification-debuginfo.x86_64: I: checking
perl-autovivification-debuginfo.x86_64: I: checking-url http://search.cpan.org/dist/autovivification/ (timeout 10 seconds)
perl-autovivification.spec: I: checking-url http://search.cpan.org/CPAN/authors/id/V/VP/VPIT/autovivification-0.09.tar.gz (timeout 10 seconds)
5 packages and 1 specfiles checked; 0 errors, 9 warnings.

Don't understand why expat marks "lexically" as a spelling error. And "Dereferencing" is a usual term. No real issues.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPL+ or Artistic
[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    ef96ee3912ec2d47938b2dcb55e96b4b  autovivification-0.09.tar.gz
    ef96ee3912ec2d47938b2dcb55e96b4b  autovivification-0.09.tar.gz.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[X] MUST: A package must own all directories that it creates.
    What about the folder /usr/lib/perl5/vendor_perl/auto? It is not owned by 
    your package. Which package provides it? I was searching with yum for the
    source, and the following packages include such a folder:

    perl-Search-Xapian-1.0.20.0-4
    perl-redland-1.0.11.1-6
    hamlib-perl-1.2.12-3
    perl-KinoSearch-0.31-2
    perl-GO-TermFinder-0.82-8
    perl-hivex-1.2.5-2
    perl-Class-Date-1.1.9-10
    perl-Filesys-Df-0.92-9
    perl-eperl-2.2.14-17
    gdal-perl-1.7.3-9
    perl-Sys-CPU-0.51-5
    liboping-1.5.1-2
    perl-digidoc-0.3.0-6
    cman-3.1.5-1
    cyrus-imapd-utils-2.4.10-2
    perl-Sys-Guestfs-1.10.7-1

    No one of them seems to be in the "Requires" list:

    libc.so.6  
    libc.so.6(GLIBC_2.0)  
    libc.so.6(GLIBC_2.1.3)  
    perl >= 0:5.008003
    perl(:MODULE_COMPAT_5.14.1)  
    perl(XSLoader)  
    perl(strict)  
    perl(warnings)  
    rpmlib(CompressedFileNames) <= 3.0.4-1
    rpmlib(FileDigests) <= 4.6.0-1
    rpmlib(PayloadFilesHavePrefix) <= 4.0-1
    rtld(GNU_HASH)  
    rpmlib(PayloadIsXz) <= 5.2-1

    I'm unsure what to do here.
    
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
    I assume the packager has tested it. Don't know how to test it on my
system.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[.] SHOULD: Your package should contain man pages for binaries/scripts.

(In reply to comment #2)
> [X] MUST: A package must own all directories that it creates.
>     What about the folder /usr/lib/perl5/vendor_perl/auto? It is not owned by 
>     your package. Which package provides it? I was searching with yum for the
>     source, and the following packages include such a folder:

It's supposed to be owned by perl (or perl-libs). Must have got lost when mmaslano removed and then restored perls vendorarch directory. I'll fix it.

(In reply to comment #3)
> (In reply to comment #2)
> > [X] MUST: A package must own all directories that it creates.
> >     What about the folder /usr/lib/perl5/vendor_perl/auto? It is not owned by 
> >     your package. Which package provides it? I was searching with yum for the
> >     source, and the following packages include such a folder:
> 
> It's supposed to be owned by perl (or perl-libs). Must have got lost when
> mmaslano removed and then restored perls vendorarch directory. I'll fix it.

Fixed in git for f15, f16, and rawhide (f14 isn't affected). perl-libs will own %{_libdir}/perl5/vendor_perl/auto. And since perl requires perl-libs, it's guaranteed to be owned when any perl module installs something there.

Well done - it seems no-one else spotted this for 11 months.

OK, after you made sure that the mentioned folder has an owner, your package is

APPROVED.

New Package SCM Request
=======================
Package Name: perl-autovivification
Short Description: Lexically disable autovivification
Owners: iarnell
Branches: f14 f15 f16
InitialCC: perl-sig

Git done (by process-git-requests).

perl-autovivification-0.09-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-autovivification-0.09-1.fc16

perl-autovivification-0.09-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-autovivification-0.09-1.fc15

perl-autovivification-0.09-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-autovivification-0.09-1.fc14

perl-autovivification-0.09-1.fc14 has been pushed to the Fedora 14 stable repository.

perl-autovivification-0.09-1.fc15 has been pushed to the Fedora 15 stable repository.

perl-autovivification-0.09-1.fc16 has been pushed to the Fedora 16 stable repository.