Bug 730083

Summary: e2fsprogs needs to build with partial relro support
Product: Red Hat Enterprise Linux 6 Reporter: Steve Grubb <sgrubb>
Component: e2fsprogsAssignee: Eric Sandeen <esandeen>
Status: CLOSED ERRATA QA Contact: BaseOS QE - Apps <qe-baseos-apps>
Severity: low Docs Contact:
Priority: urgent    
Version: 6.1CC: iboverma, jrieden, rwheeler, sct
Target Milestone: rc   
Target Release: 6.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: e2fsprogs-1.41.12-10.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 13:18:07 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 584498, 846801, 846802    

Description Steve Grubb 2011-08-11 13:47:10 EDT
Description of problem:
Description of problem:
The e2fsprogs package contains libraries (specifically libcomm_err). We would like them to be built with partial RELRO support as a security enhancement.

Additional info:
Partial RELRO requires these passed at link: -Wl,-z,relro 
You can fix this by patching the Makefiles to add this link flag to LDFLAGS or you might be able to simply add LDFLAGS="$LDFLAGS -Wl,-z,relro" to the configure line in the rpm's spec file. You will have to test the built packages to ensure the flags are properly passed all the way to the end of build. It does not hurt anything if the package contains applications that pick up partial relro support, too.
Comment 1 Ric Wheeler 2011-08-11 14:59:23 EDT
I don't understand why this is reported as an issue 4 days before it is due to be resolved?

We have a planning phase that closed a long time ago. That is when you need to make this kind of request please!
Comment 2 Eric Sandeen 2011-08-11 15:05:45 EDT
Aside from the poor timing, can I get a little background?

What are the implications of this?  Should the entire package build with
those flags?  What does this fix, and why is libcom_err so special in this
regard?
Comment 3 Eric Sandeen 2011-08-12 13:36:41 EDT
Built & tagged in e2fsprogs-1.41.12-10.el6 

[root@inode tmp]# ./rpm-chksec libcom_err e2fsprogs-libs libss e2fsprogs
FILE                                                    TYPE      RELRO    PIE 
/lib64/libcom_err.so.2.1                                library   partial  DSO 
/lib64/libe2p.so.2.3                                    library   partial  DSO 
/lib64/libext2fs.so.2.4                                 library   partial  DSO 
/lib64/libss.so.2.0                                     library   partial  DSO 
/sbin/badblocks                                         exec      partial  no  
/sbin/debugfs                                           exec      partial  no  
/sbin/dumpe2fs                                          exec      partial  no  
/sbin/e2fsck                                            exec      partial  no  
/sbin/e2image                                           exec      partial  no  
/sbin/e2label                                           exec      partial  no  
/sbin/e2undo                                            exec      partial  no  
/sbin/fsck.ext2                                         exec      partial  no  
/sbin/fsck.ext3                                         exec      partial  no  
/sbin/fsck.ext4                                         exec      partial  no  
/sbin/fsck.ext4dev                                      exec      partial  no  
/sbin/logsave                                           exec      partial  no  
/sbin/mke2fs                                            exec      partial  no  
/sbin/mkfs.ext2                                         exec      partial  no  
/sbin/mkfs.ext3                                         exec      partial  no  
/sbin/mkfs.ext4                                         exec      partial  no  
/sbin/mkfs.ext4dev                                      exec      partial  no  
/sbin/resize2fs                                         exec      partial  no  
/sbin/tune2fs                                           exec      partial  no  
/usr/bin/chattr                                         exec      partial  no  
/usr/bin/lsattr                                         exec      partial  no  
/usr/sbin/e2freefrag                                    exec      partial  no  
/usr/sbin/filefrag                                      exec      partial  no  
/usr/sbin/mklost+found                                  exec      partial  no
Comment 6 errata-xmlrpc 2011-12-06 13:18:07 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1735.html