Bug 730325

Summary: Review Request: telepathy-kde-approver - KDE Channel Approver for Telepathy
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: Package ReviewAssignee: Radek Novacek <rnovacek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, ovasik, package-review, rnovacek
Target Milestone: ---Flags: rnovacek: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-15 13:59:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 723123    
Bug Blocks: 656997    

Comment 1 Radek Novacek 2011-09-12 13:21:24 UTC
Name: ok
License: wrong, spec says GPLv2+, source is LGPLv2+
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-approver_%{version}.tar.bz2
instead of 
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-approver_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: not needed
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint:
telepathy-kde-approver.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)

Comment 2 Rex Dieter 2011-09-14 19:28:17 UTC
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-approver.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-approver-0.1.0-2.fc15.src.rpm

%changelog
* Wed Sep 14 2011 Rex Dieter <rdieter@fedoraproject.org> 0.1.0-2
- License: LGPLv2+
- fix Source0 URL
- fix tabs/spaces

Comment 3 Radek Novacek 2011-09-15 06:59:10 UTC
Thanks for fixing the issues, setting fedora-review+.

Comment 4 Rex Dieter 2011-09-15 13:39:30 UTC
New Package SCM Request
=======================
Package Name: telepathy-kde-approver
Short Description: KDE Channel Approver for Telepathy
Owners: jreznik rdieter
Branches: f15 f16

Comment 5 Gwyn Ciesla 2011-09-15 13:47:45 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2011-09-15 13:59:31 UTC
imported.