Bug 730327

Summary: Review Request: telepathy-kde-filetransfer-handler - Telepathy file transfer handler
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: Package ReviewAssignee: Radek Novacek <rnovacek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, ovasik, package-review, rnovacek
Target Milestone: ---Flags: rnovacek: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-18 17:41:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 723123    
Bug Blocks: 656997    

Comment 1 Radek Novacek 2011-09-12 14:06:37 UTC
Name: ok
License: ok
Source: wrong URL, should be
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-filetransfer-handler_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-filetransfer-handler_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: NA
Desktop file validations: not needed
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint:
telepathy-kde-filetransfer-handler.spec:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)
telepathy-kde-filetransfer-handler.src: W: invalid-url URL: https://projects.kde.org/projects/playground/network/telepathy/telepathy-file-handler HTTP Error 404: Not Found
telepathy-kde-filetransfer-handler.x86_64: W: no-manual-page-for-binary telepathy-kde-filetransfer-handler

Comment 2 Rex Dieter 2011-09-15 13:37:34 UTC
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-filetransfer-handler.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-filetransfer-handler-0.1.0-2.fc15.src.rpm

%changelog
* Thu Sep 15 2011 Rex Dieter <rdieter> 0.1.0-2
- fix Source0 URL
- fix tabs/spaces

Comment 3 Radek Novacek 2011-09-16 06:27:13 UTC
Thanks for fixing the issues, setting fedora-review+.

Comment 4 Rex Dieter 2011-09-16 14:36:52 UTC
New Package SCM Request
=======================
Package Name: telepathy-kde-filetransfer-handler
Short Description: Telepathy file transfer handler
Owners: jreznik rdieter
Branches: f15 f16

Comment 5 Gwyn Ciesla 2011-09-17 01:59:42 UTC
Git done (by process-git-requests).

Comment 6 Rex Dieter 2011-09-18 17:41:31 UTC
imported.