Bug 730328

Summary:	Review Request: telepathy-kde-presence-applet - Plasma applet for managing your Telepathy account presence
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	Package Review	Assignee:	Radek Novacek <rnovacek>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	kevin, notting, ovasik, package-review, rnovacek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-09-25 21:54:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	730329
Bug Blocks:	656997

Description Rex Dieter 2011-08-12 13:56:54 UTC

Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet-0.1.0-1.fc14.src.rpm
Description: Plasma applet for managing your Telepathy account presence

Comment 1 Radek Novacek 2011-09-13 07:42:56 UTC

Name: ok
License: ok
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
BRs/Reqs: I believe it should have dependency on kdebase-runtime (plasma qml stuff)
    BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: not needed
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint:
telepathy-kde-presence-applet.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4)

Comment 2 Kevin Kofler 2011-09-25 21:54:54 UTC

This got resubmitted (by the same submitter) and completed (by the same reviewer) in bug #740562.

*** This bug has been marked as a duplicate of bug 740562 ***

Comment 3 Kevin Kofler 2011-09-25 21:58:27 UTC

Actually, the review in the newer bug is also not yet complete, but it has a newer SRPM available.