Bug 730736
| Summary: | [RFE] obsolete validateStorageServerConnection | |||
|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Haim <hateya> | |
| Component: | vdsm | Assignee: | Allon Mureinik <amureini> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | lkuchlan <lkuchlan> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 3.3 | CC: | abaron, acanan, amureini, bazulay, bugs, danken, hateya, iheim, mgoldboi, michal.skrivanek, sherold, yeylon, ykaul | |
| Target Milestone: | --- | Keywords: | CodeChange, FutureFeature, Reopened | |
| Target Release: | 3.6.0 | Flags: | amureini:
ovirt_requires_release_note?
|
|
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | storage | |||
| Fixed In Version: | ovirt-3.6.0-alpha1.2 | Doc Type: | Deprecated Functionality | |
| Doc Text: |
As of the VDSM included in 3.6.0 (exact build number pending official build), VDSM will no longer support engines older than 3.3.0. It will, however, continue to support clusters and data centers with compatibility versions lower than 3.3 defined on newer engine installations.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1215387 (view as bug list) | Environment: | ||
| Last Closed: | 2015-11-04 12:57:46 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1215387 | |||
|
Description
Haim
2011-08-15 15:00:56 UTC
Using validateStorageServerConnection to check connectivity is wrong, as it is inherently raceful - connectivity may be lost just after checking it succeeds. Like you, I do not see any reason to make validateStorageServerConnection see another day. Ayal, any insight? currently, rhevm commands divided to 2 main phases: CanDoAction and Execute. the CanDoAction is meant to return a fast and as much as possible reliable answer to the user if the command will succeed, and give better error and frontend handling. before connecting to a storage there is a check in CanDoAction to see if it should succeed, therefore i think the opposite: this verb should be fixed and rhevm should check where it is can used more. although there is a race, and this we cannot solve, there are many cases it would save the user getting errors during execution. Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug. The engine's use of validateStorageServerConnection was removed in 3.3.0, and I'd really like to remove it from VDSM too. The only "snag" here is that removing it from VDSM will break it's backwards-compatible ability to going a 3.2 cluster managed by a 3.2 engine. Scott/Itamar - in what version will we be able to do this? In 3.6 since will only be used on .el7 / >= 3.4 engine. Flagging requires_doc_text as this change needs to be documented and requires_release_note? for consideration whether or not this should be in the release notes, or whether the doctext is enough. Tested using: ovirt-engine-3.6.0-0.0.master.20150519172219.git9a2e2b3.el6.noarch vdsm-4.17.0-822.git9b11a18.el7.noarch Verification instructions: 1. Run "vdsClient" and verify that "validateStorageServerConnection" is no longer there. oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue. If problems still persist, please open a new BZ and reference this one. |