Bug 732025
Summary: | [RFE] Make rows in jobs view thin (patch included) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] Beaker | Reporter: | Marian Ganisin <mganisin> | ||||||||
Component: | web UI | Assignee: | Raymond Mancy <rmancy> | ||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||||||
Severity: | unspecified | Docs Contact: | |||||||||
Priority: | unspecified | ||||||||||
Version: | 0.7 | CC: | bpeck, dcallagh, ebaak, mcsontos, rmancy, stl | ||||||||
Target Milestone: | --- | Keywords: | Patch | ||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2012-07-27 01:38:11 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Marian Ganisin
2011-08-19 14:11:17 UTC
Apologies, these are being bumped to next maint release. Created attachment 598548 [details]
screenshot of padding on job page
Export link on job page has weird left padding (see attached screenshot). Probably just needs class="job-action" removed from it on this page, or the CSS rule for job-action updated to be specific to the grid.
What's even worse, is that the only thing keeping the 'Clone Delete Export' on seperate lines is that the 'Delete' is now a block level element and clears both left and right. When we don't have 'Cancel' instead of 'Delete', they are all shown on the same line (ala the jobs page), which just looks wrong. When we *do* have Cancel rather... (In reply to comment #6) > What's even worse, is that the only thing keeping the 'Clone Delete Export' > on seperate lines is that the 'Delete' is now a block level element and > clears both left and right. When we don't have 'Cancel' instead of 'Delete', > they are all shown on the same line (ala the jobs page), which just looks > wrong. Why do same elements have different rendering options? Patch in this bug just removed br tags and added brackets for better separation of links, neither padding nor any other formatting. Elements were all inline (despite to different classes assigned what is still little bit weird for unfamiliar person) and as far as I can say it is working quite fine. Why to not implement it that way? (In reply to comment #9) > (In reply to comment #6) > > What's even worse, is that the only thing keeping the 'Clone Delete Export' > > on seperate lines is that the 'Delete' is now a block level element and > > clears both left and right. When we don't have 'Cancel' instead of 'Delete', > > they are all shown on the same line (ala the jobs page), which just looks > > wrong. > > Why do same elements have different rendering options? Patch in this bug > just removed br tags and added brackets for better separation of links, > neither padding nor any other formatting. Elements were all inline (despite > to different classes assigned what is still little bit weird for unfamiliar > person) and as far as I can say it is working quite fine. Why to not > implement it that way? The main reason why we got rid of the brackets is that similar actions on other pages use them, so we just thought we would try and keep it consistent. The only issue was that there was another change which changed 'Delete' to be a block level element, and so items would display differently depending on whether 'Delete' was shown or not. Created attachment 599027 [details]
This is with a narrow screen
Because of 822492, a whiteboard entry of sufficient size (or a narrow screen) can cause the action items to wrap. http://gerrit.beaker-project.org/#/c/1226/ Oops, I missed closing this bug. Beaker 0.9.1 was released last week. |