| Summary: | fence_ipmi exposes user password on verbose mod | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Simon Grinberg <sgrinber> | ||||
| Component: | fence-agents | Assignee: | Marek Grac <mgrac> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 6.1 | CC: | abaron, acathrow, bazulay, cluster-maint, djansa, iheim, rsteiger, ykaul | ||||
| Target Milestone: | beta | Keywords: | Security | ||||
| Target Release: | 6.2 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fence-agents-3.1.5-9.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-12-06 12:23:11 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 743047, 1241648 | ||||||
| Attachments: |
|
||||||
|
Comment 2
Itamar Heim
2011-08-22 11:10:40 UTC
There's an element of "don't do that" here. Verbose mode is for debugging, and one possible error an administrator may do is mistype a password. The easiest thing to do is remove the feedback for what fence_ipmilan is forking. user can see the password typed from command line so there is no reason to log it even in verbose mode. Created attachment 519294 [details]
Possible fix
(In reply to comment #5) > user can see the password typed from command line so there is no reason to log > it even in verbose mode. Users are not restricted to calling fencing agents from the command line to debug configurations (and in fact, they rarely do), so this argument does not really apply. It's better to change the output than not; I've attached a patch that changes it to "[set]" in what is printed instead of the password contents. Patch is now in upstream: http://git.fedorahosted.org/git/?p=fence-agents.git;a=commit;h=61a7bb3addd3862833f5cf23725d378c563a10c5 Unit test: Befora applying patch: ./fence_ipmilan -o status -a dell-ipmi -l root -p PASS -v Getting status of IPMI:dell-ipmi...Spawning: '/usr/bin/ipmitool -I lan -H 'dell-ipmi' -U 'root' -P 'PASS' -v chassis power status'... Chassis power = On Done After applying patch: ./fence_ipmilan -o status -a dell-ipmi -l root -p PASS -v Getting status of IPMI:dell-ipmi...Spawning: '/usr/bin/ipmitool -I lan -H 'dell-ipmi' -U 'root' -P '[set]' -v chassis power status'... Chassis power = On Done Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1599.html |