| Summary: | fix rhn.py to quote arguments | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Andrew Cathrow <acathrow> | ||||||||
| Component: | ovirt-node | Assignee: | Alan Pevec <apevec> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 6.2 | CC: | apevec, cpelland, cshao, gouyang, jboggs, kli, leiwang, mburns, moli, ovirt-maint, rbalakri, ycui, yeylon | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | ovirt-node-2.0.2-0.3.gitcf213a7.el6 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-12-06 19:26:27 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 728234 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andrew Cathrow
2011-08-22 12:58:41 UTC
Below is QE summary about register RHEVH to Satellite with special character password:
Fail:
(123qwe
)123qwe
;123qwe
"123qwe
<123qwe
">123qwe"
123 qwe(there is blank)
#123qwe
$123qwe
&123qwe
Pass:
[123qwe
]123qwe
{123qwe
}123qwe
:123qwe
,123qwe
.123qwe
/123qwe
?123qwe
~123qwe
!123qwe
%123qwe
^123qwe
*123qwe
@123qwe
rhn/proxy user/password are now single quoted to escape the characters Some issues with a sequence. subprocess.Popen handles sequenced args as shell arguments rather than arguments to the program being called. No reason to create a list to have it rejoined in the end as a string. Can easily fix with single quotes on user managed options that could possibly have special characters and spaces. Created attachment 519801 [details]
ovirt.log
> No reason to create a list to have it rejoined in the end as a string.
Actually, there's a reason: list2cmdline should do proper quoting for you,
so it's best to send args as a list.
quoting around the password where we need quotes gets mangled when quotes are in the password itself all other bad characters are fine. Even escaping them ahead of time makes the situation worse. any ideas? list2cmdline put into sample script with output http://pastebin.test.redhat.com/59937 Not sure I understand, afaict list2cmdline does correct thing, don't escape or quote anything, just send it as a list to Popen and it will quote/escape as needed. (In reply to comment #1) > Below is QE summary about register RHEVH to Satellite with special character > password: How did you create those? When I tried to put space in RHN Hosted it said: Password must be ASCII and cannot contain the following special characters (") (<) (>) (space) Created attachment 521128 [details]
fix rhn.py to quote arguments
Created attachment 521282 [details]
fix rhn.py to quote arguments
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2011-1783.html |