Bug 732557
| Summary: | Macro %makeinstall used, and not escaped in %changelog | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Moritz Barsnick <moritz> |
| Component: | less | Assignee: | Vojtech Vitek <vvitek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hripps, vvitek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-23 11:13:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Thanks! Will be fixed in less-444-3.fc17. |
Description of problem: The %makeinstall isn't supposed to be used. And when naming a macro in the %changelog, it should be escaped. (Yes, technically, these are two bugs.) Version-Release number of selected component (if applicable): 444-2.fc17 How reproducible: always Steps to Reproduce: 1. read SPEC file and regarding the %changelog: 2. rpm -qp --changelog Actual results: 1. has no obvious side effects. See Fedora Packaging rule below. 2. The missing '%' in %changelog leads to this: * Fri Aug 12 2011 Vojtech Vitek (V-Teq) <vvitek> - 444-2 - Fix debuginfo source files permissions - Remove strip after /usr/bin/make \ prefix=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr \ exec_prefix=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr \ bindir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/bin \ sbindir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/sbin \ sysconfdir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/etc \ datadir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/share \ includedir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/include \ libdir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/lib64 \ libexecdir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/libexec \ localstatedir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/var \ sharedstatedir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/var/lib \ mandir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/share/man \ infodir=/builddir/build/BUILDROOT/less-444-2.fc17.x86_64/usr/share/info \ install to fix debuginfo package Expected results: * Fri Aug 12 2011 Vojtech Vitek (V-Teq) <vvitek> - 444-2 - Fix debuginfo source files permissions - Remove strip after %makeinstall to fix debuginfo package Additional info: Regarding the use of %makeinstall: http://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used To be able to quote %macros in %changelog, escape them in the SPEC file: "- Remove strip after %makeinstall to fix debuginfo package" => "- Remove strip after %%makeinstall to fix debuginfo package"