Bug 732571

Description of problem:
Invoking the snapshotMeasurementTables admin test operation returns an empty HTML table if the back-end database is Oracle.

The server log reveals the following error message:


Version-Release number of selected component (if applicable):
RHQ 3.0.1

How reproducible:
Always

Steps to Reproduce:
1. Using a Oracle database for the RHQ installation, navigate to http://localhost:7080/admin/test/control.jsp?mode=snapshotMeasurementTables
  
Actual results:
Near the top of the page:
Executed snapshotMeasurementTables: <table></table>

Expected results:
Near the top of the page:
Executed snapshotMeasurementTables: <table><tr><td>r00</td><td>113806</td></tr><tr><td>r01</td><td>0</td></tr><tr><td>r02</td><td>139520</td></tr><tr><td>r03</td><td>148381</td></tr><tr><td>r04</td><td>191861</td></tr><tr><td>r05</td><td>132352</td></tr><tr><td>r06</td><td>132355</td></tr><tr><td>r07</td><td>9223</td></tr><tr><td>r08</td><td>132347</td></tr><tr><td>r09</td><td>132353</td></tr><tr><td>r10</td><td>132357</td></tr><tr><td>r11</td><td>132350</td></tr><tr><td>r12</td><td>132349</td></tr><tr><td>r13</td><td>132355</td></tr><tr><td>r14</td><td>132353</td></tr><tr><td>oneHour</td><td>493763</td></tr><tr><td>sixHour</td><td>179715</td></tr><tr><td>oneDay</td><td>227058</td></tr><tr><td>trait</td><td>67390</td></tr><tr><td>bline</td><td>1680</td></tr><tr><td>oob</td><td>18</td></tr><tr><td>oob_temp</td><td>12</td></tr><tr><td>callkey</td><td>0</td></tr><tr><td>calldata</td><td>0</td></tr><tr><td>enabledMetricSchedules</td><td>3721</td></tr><tr><td>enabledTraitSchedules</td><td>1742</td></tr><tr><td>enabledCalltimeSchedules</td><td>0</td></tr></table>

Additional info:
This issue is due to the concatenation of the query string in org.rhq.enterprise.server.test.MeasurementTestBean.snapshotMeasurementTables(). Specifically, at line 229 we check to see if databaseType is Oracle and if it is, set querySuffix "from dual;". The problem with this is that on line 240 we put the snapshotQuery and querySuffix together without a space resulting in the end of the query becoming: "as enabledCalltimeSchedulesfrom dual;"

To fix this, we will need to change line 230 to:

            querySuffix = " from dual;";