Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 732645

Summary:	Coverity scan revealed defects
Product:	Red Hat Enterprise Linux 6	Reporter:	Michal Luscon <mluscon>
Component:	sanlock	Assignee:	David Teigland <teigland>
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	low	Docs Contact:
Priority:	low
Version:	6.2	CC:	ajia, kdudka
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sanlock-1.8-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-09-19 15:29:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Luscon 2011-08-23 07:57:29 UTC

Description of problem:

1.
src/client_resource.c:123 - Comparing "opt_in" to null implies that "opt_in" might be null.
src/client_resource.c:173 - Passing null variable "opt_in->str" to function "send", which dereferences it.

2.
/src/client_resource.c:649 - Dereferencing "str" (line #620) before a null check.

Version-Release number of selected component (if applicable):
1.7-4

Additional info:
These defects were found by analysis of coverity scan report.

Comment 3 David Teigland 2011-08-23 16:36:20 UTC

Thanks, I'm looking at the full list and making fixes.

Comment 4 David Teigland 2011-08-23 17:05:37 UTC

made the following changes
1. handle error from direct_align
2. free mem in leader_read_multiple
3. handle null str arg in str_to_lockspace

none are a problem in practice,
1 won't happen
2 code is unused
3 invalid use

If I do another 6.2 build for other reasons, these changes will be included, otherwise not.  Don't know what state to put this bz in.

Comment 7 David Teigland 2011-09-19 15:29:01 UTC


*** This bug has been marked as a duplicate of bug 658971 ***