Bug 732676

Summary: esx driver: failed to access datastore (/folder) on virtualcenter with paths
Product: [Community] Virtualization Tools Reporter: Juan Carlos Moreno <juancarlos.moreno>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: crobinso, eblake, matthias.bolte, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-23 13:33:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch for dcPath none

Description Juan Carlos Moreno 2011-08-23 09:57:41 UTC 
Description of problem:

if you have a virtualcenter where you classify your datacenter into folders, you are unable to access datastore, returning a 404 not found.

Mi list of folder is like:

https://vcenter/folder :

Index of datacenters

Path
OWN/MYDC1
OWN/MYDC2
CUSTOMER/CUSTOMER1DC
CUSTOMER/CUSTOMER2DC

the command:

virsh -d5 -c vpx://vcenterIP/MYDC1/CLUSTER/esx001?no_verify=1 dumpxml virtualmachine
 
error: internal error HTTP response code 404 for download from 'https://vcenterIP:443/folder/virtualmachine/virtualmachine.vmx?dcPath=MYDC1&dsName=vmstorage'

dcPath should be "OWN/MYDC1"

Version-Release number of selected component (if applicable):

lastest-build (libvirt-0.9.4xxx)

How reproducible:

create a folder in your virtualcenter and then move your datacenter inside, you will recieve a 404 when requesting a "dumpxml" command.

please, see patch attached for a possible solution.

Hope that helps.
Juan Carlos
Comment 1 Dave Allan 2011-08-23 15:35:10 UTC 
Thanks for the bugreport and the patch; I don't see it attached, though?
Comment 2 Juan Carlos Moreno 2011-08-24 09:28:13 UTC 
Created attachment 519578 [details]
patch for dcPath

the patch.
Comment 3 Eric Blake 2011-08-24 13:53:44 UTC 
You may get faster review if you also send your patch upstream, to libvir-list
Comment 4 Matthias Bolte 2011-08-24 14:19:08 UTC 
The common vpx:// URI format is like this

vpx://[username@]hostname[:port]/[datacenter[/cluster]/server]

The actual problem here is that the driver doesn't handle folders yet. In your case the correct URI should look like this once the driver can handle folders

vpx://vcenterIP/OWN/MYDC1/CLUSTER/esx001?no_verify=1

and OWN/MYDC1 is the datacenter part. As you can probably create folders (and even nest them) on all levels of the datacenter/cluster/server path the driver needs to deal with complexer paths.

Your patch works around this by adding a query parameter. That's fine for your special case. But the general solution will be to make the URI path handling aware of folders.

I'll have a look at that.
Comment 5 Matthias Bolte 2011-09-06 20:42:51 UTC 
I posted a patch to the mailing list that allows you to specify folders in the path of the connection URI as suggested:

https://www.redhat.com/archives/libvir-list/2011-September/msg00345.html

While implementing this I found a bug in the driver and fixed it. This patch is a prerequisite for the first one:

https://www.redhat.com/archives/libvir-list/2011-September/msg00344.html
Comment 6 Juan Carlos Moreno 2011-09-07 08:00:53 UTC 
Hi Matthias,

ok, thank you. I'will try it!

Best regards,

Juan Carlos Moreno
juancarlos.moreno
Project Manager
Comment 7 Cole Robinson 2016-03-23 13:33:37 UTC 
That patch was pushed upstream:

commit 23247a1efd9ab41204e434aaf6798b7f807c4c31
Author: Matthias Bolte <matthias.bolte>
Date:   Tue Nov 1 17:12:37 2011 +0100

    esx: Support folders in the path of vpx:// connection URIs