Bug 733094
| Summary: | Cloning repo with filter and origin feed ends with traceback | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | Preethi Thomas <pthomas> |
| Component: | user-experience | Assignee: | Sayli Karmarkar <skarmark> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.0.0 | CC: | cperry, skarmark |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-24 20:15:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
If a parent repo has filters and cloned with a origin feed. We probably should ignore the filters in the cloned repo and rely on the origin to handle the filtering. We should'nt raise a pulp exception. Regarding the client error, we should handle progress None on the client. This seems to be already fixed. $ sudo pulp-admin repo clone --id f15-i386 --clone_id foo1 --filter test-filter --feed origin -F error: error: operation failed: Filters cannot be applied to clones with origin feed [root@preethi ~]# rpm -q pulp pulp-0.0.255-1.fc15.noarch [root@preethi ~]# sudo pulp-admin repo clone --id f15 --clone_id def --feed=origin --filter blacklist -F error: error: operation failed: Filters cannot be applied to clones with origin feed Pulp v1.0 is released Closed Current Release. Pulp v1.0 is released. |
Description of problem: Needs a better error message if you try to clone a repo with filter and origin feedback [root@preethi ~]# pulp-admin repo clone --id=f15 --clone_id=f15-clone2 --feed=origin --filter=filter-black -F Repository [f15] is being cloned as [f15-clone2] Waiting - Traceback (most recent call last): File "/usr/bin/pulp-admin", line 23, in <module> admin.main() File "/usr/lib/python2.7/site-packages/pulp/client/lib/cli.py", line 152, in main command.main(self.args[1:]) File "/usr/lib/python2.7/site-packages/pulp/client/pluginlib/command.py", line 129, in main action.main(args[1:]) File "/usr/lib/python2.7/site-packages/pulp/client/pluginlib/command.py", line 211, in main self.run() File "/usr/lib/python2.7/site-packages/pulp/client/admin/plugins/repo.py", line 605, in run self.clone_foreground(task) File "/usr/lib/python2.7/site-packages/pulp/client/admin/plugins/repo.py", line 578, in clone_foreground self.print_clone_finish(task['state'], task['progress']) File "/usr/lib/python2.7/site-packages/pulp/client/admin/plugins/repo.py", line 559, in print_clone_finish current += self.form_progress_item_details(progress["details"]) TypeError: 'NoneType' object is not subscriptable Version-Release number of selected component (if applicable): [root@preethi ~]# rpm -q pulp pulp-0.0.226-1.fc14.noarch From pulp.log 2011-08-24 14:20:40,714 15346:139731493529344: pulp.server.tasking.task:ERROR: task:382 Task failed: Task c51b9299-ce7d-11e0-8682-002564a85a58: _clone(f15, f15-clone3, f15-clone3, origin, None, None, ['filter-black'], progress_callback=<bound method Task.progress_callback of <pulp.server.tasking.task.Task object at 0x7f15aaa53790>>) Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/pulp/server/tasking/task.py", line 331, in run result = self.callable(*self.args, **self.kwargs) File "/usr/lib/python2.7/site-packages/pulp/server/api/repo_sync.py", line 112, in _clone repo_api.add_filters(clone_id, filter_ids=filters) File "/usr/lib/python2.7/site-packages/pulp/server/api/repo.py", line 1777, in add_filters raise PulpException("Filters can be added to repos with 'local' feed only") PulpException: "Filters can be added to repos with 'local' feed only"