Bug 733168

Summary: Persistent store plugin uses inconsistent kibibyte abbreviations
Product: Red Hat Enterprise MRG Reporter: Paul Colby <redhat>
Component: qpid-cppAssignee: messaging-bugs <messaging-bugs>
Status: CLOSED NEXTRELEASE QA Contact: MRG Quality Engineering <mrgqe-bugs>
Severity: low Docs Contact:
Priority: unspecified    
Version: DevelopmentCC: kim.vdriet
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-08-25 22:26:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch against http://anonsvn.jboss.org/repos/rhmessaging/store/trunk r4471.
none
Patch against http://anonsvn.jboss.org/repos/rhmessaging/store/tags/qpid-0.10-release/cpp r4468. none

Description Paul Colby 2011-08-25 01:28:42 UTC
Created attachment 519745 [details]
Patch against http://anonsvn.jboss.org/repos/rhmessaging/store/trunk r4471.

Description of problem:
Currently, the qpidd C++ broker's help text show's KiB in some places and kiB in others.  It would be nice it these were consistent.  The inconsistent ones come from the rhm_store plugin.

How reproducible:
  Always.

Steps to Reproduce:
1. qpidd --help | grep -i '[kmt]i\?b'

Actual results:
  --num-jfiles N (8)            Default number of files for each journal
                                of read pages (1 read page = 64kiB)
                                KiB. Allowable values - powers of 2: 1, 2, 4,
  --tpl-num-jfiles N (8)        Number of files for transaction prepared list
                                64kiB)
                                list write page cache in KiB. Allowable values
  --cluster-size N (1)       Wait for N cluster members before allowing clients

Expected results:
  --num-jfiles N (8)            Default number of files for each journal
                                of read pages (1 read page = 64KiB)
                                KiB. Allowable values - powers of 2: 1, 2, 4,
  --tpl-num-jfiles N (8)        Number of files for transaction prepared list
                                64KiB)
                                list write page cache in KiB. Allowable values
  --cluster-size N (1)       Wait for N cluster members before allowing clients

Additional info:
  I'll attached a two very simple diff's that would address the issue - one diff against the 0.10 tag, and one against the current trunk (r4471).

Comment 2 Paul Colby 2011-08-25 01:32:44 UTC
This issue was originally reported at https://issues.apache.org/jira/browse/QPID-3420, but moved here since the persistent store plugin in not owned by the Qpid project directly.

Comment 3 Kim van der Riet 2011-08-25 12:40:33 UTC
Thanks for the patch. Fixed on trunk r.4472

Comment 4 Paul Colby 2011-08-25 22:26:25 UTC
You're very welcome :)

I'll close the issue now.