Bug 733537

I would run needs-restarting [as root] after each 'yum update' on my F15[x86_64] install, and never saw any output from it.

I also am running F15 (x86_64), desktop is KDE. I run needs-restarting after using yumex to update, both as root and as user.  It never produces any output for me.

okay I have a patch which HELPS this problem dramatically but there are some corner cases (only on fedora, sadly) where solving it will be a challenge.

http://yum.baseurl.org/gitweb?p=yum-utils.git;a=commitdiff;h=c53740ce33d39e5bade9b0f0af8385c1d654010b

The edge cases:
- a running program is from a package which was updated and which the original package it was installed from is no longer available in any of the repository metadata
- a running program was obsoleted and the files were not replaced by anything - where the deleted files are not a binary but some library.

grab a newer needs-restarting from yum-utils git and give it a try, please.

I doubt that the edge cases will be too important, considering that (for me, at least) the current version of needs-restarting missed firefox, thunderbird and a kernel update.  Please post a pointer to the new version so I can try it, as I'm not familiar with git.

I've tried the following [on F15 x86_64]- expecting some output - but saw none.

wget -o needs-restarting "http://yum.baseurl.org/gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;h=20415e61582ab77bc4ba0b23f9624e916e5ede17;hb=c53740ce33d39e5bade9b0f0af8385c1d654010b"
chmod a+x needs-restarting
yum downgrade gnome-shell
./needs-restarting

I tried using that wget command to replace needs-restarting (as root) and found that the chmod wasn't needed.  I didn't try the yum downgrade because I don't use gnome-shell, but tried needs-restarting to see what happened:

[joe@barrayar Desktop]$ needs-restarting
/usr/bin/needs-restarting: line 1: --2011-08-27: command not found
/usr/bin/needs-restarting: line 2: Resolving: command not found
/usr/bin/needs-restarting: line 3: 140.211.167.207: command not found
/usr/bin/needs-restarting: line 3: :80...: command not found
/usr/bin/needs-restarting: line 3: Connecting: command not found
/usr/bin/needs-restarting: line 4: HTTP: command not found
/usr/bin/needs-restarting: line 5: Length:: command not found
/usr/bin/needs-restarting: line 6: Saving: command not found
/usr/bin/needs-restarting: line 8: 0K: command not found
/usr/bin/needs-restarting: line 10: syntax error near unexpected token `('
/usr/bin/needs-restarting: line 10: `2011-08-27 11:00:01 (107 KB/s) - “gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;h=20415e61582ab77bc4ba0b23f9624e916e5ede17;hb=c53740ce33d39e5bade9b0f0af8385c1d654010b” saved [5643]'

[joe@barrayar Desktop]$ cat /usr/bin/needs-restarting
--2011-08-27 11:00:01--  http://yum.baseurl.org/gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;h=20415e61582ab77bc4ba0b23f9624e916e5ede17;hb=c53740ce33d39e5bade9b0f0af8385c1d654010b
Resolving yum.baseurl.org... 140.211.167.207
Connecting to yum.baseurl.org|140.211.167.207|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: “gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;h=20415e61582ab77bc4ba0b23f9624e916e5ede17;hb=c53740ce33d39e5bade9b0f0af8385c1d654010b”

     0K .....                                                   107K=0.05s

2011-08-27 11:00:01 (107 KB/s) - “gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;h=20415e61582ab77bc4ba0b23f9624e916e5ede17;hb=c53740ce33d39e5bade9b0f0af8385c1d654010b” saved [5643]

Tried again, putting everything in ~/Downloads and got the same result.  I *think* the -o is wrong.  Tried again and got the same thing.  Please advise.

Update: the file did get downloaded, but with a weird name that I didn't expect; I found it via Thunar and got things straightened out.  I'm not sure if it works, yet, but we'll see next time there's an update.

> I *think* the -o is wrong.  Tried again and got the same thing.  Please advise.

Sorry - my mistake. The wget option is -O. [and not -o]

(In reply to comment #5)
> I've tried the following [on F15 x86_64]- expecting some output - but saw none.
> 
> wget -o needs-restarting
> "http://yum.baseurl.org/gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;h=20415e61582ab77bc4ba0b23f9624e916e5ede17;hb=c53740ce33d39e5bade9b0f0af8385c1d654010b"
> chmod a+x needs-restarting
> yum downgrade gnome-shell
> ./needs-restarting



Satish,
 Can you do the following:

for one of the processes you expect to have been marked as 'needing to be restarted' please cd /proc/$the_pid/

and attach the output of grep fd: smaps

thanks

(In reply to comment #9)

> for one of the processes you expect to have been marked as 'needing to be
> restarted' please cd /proc/$the_pid/
> 
> and attach the output of grep fd: smaps

I retried 'yum downgrade gnome-shell' - assuming gnome-shell process would need restarting. But 'grep' gave no output.

[root@asterix ~]# grep fd: /proc/*/smaps
[root@asterix ~]# 


But I guess - you might be looking for the following



[root@asterix ~]# cd /proc/2067
[root@asterix 2067]# grep deleted smaps 
00400000-00404000 r-xp 00000000 08:01 131576                             /usr/bin/gnome-shell (deleted)
00603000-00604000 rw-p 00003000 08:01 131576                             /usr/bin/gnome-shell (deleted)
7f502878a000-7f502878b000 rw-s 00000000 00:04 31833                      /drm mm object (deleted)
7f502878b000-7f502878c000 rw-s 00000000 00:04 31831                      /drm mm object (deleted)

.....

I see the format of smaps has changed.

If you could try this needs-restarting from:

http://yum.baseurl.org/gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;hb=81f18617756866700c86ae34989edc7d0e71478d


and report back.
thanks

The program seemed to "go to sleep," and after a while I killed the terminal.  However, top, in another terminal, showed that it was still running even after the terminal was closed.  As I've never had it work correctly, I don't know how long to wait; seconds, minutes?

(In reply to comment #12)
> If you could try this needs-restarting from:
> 
> http://yum.baseurl.org/gitweb?p=yum-utils.git;a=blob_plain;f=needs-restarting.py;hb=81f18617756866700c86ae34989edc7d0e71478d
> 
> 
> and report back.


Appears to work.

[after yum downgrade gnome-shell]

[root@asterix ~]# ./needs-restarting 
2010 : /usr/bin/gnome-shell 

BTW: looks like 'fd:' is now changed to '08:' [not sure if its is universally true for all installs..]

let me guess you downloaded it and ran it directly from the console?

or did you run it w/bash?

I suspect your mouse pointer changed when you run it.

please run it as:

python ./needs-restarting.py

do not run it directly or bash will be the interpreter and the 'import' command will run the command 'import'

(In reply to comment #14)

> 
> Appears to work.
> 
> [after yum downgrade gnome-shell]
> 
> [root@asterix ~]# ./needs-restarting 
> 2010 : /usr/bin/gnome-shell 
> 
> BTW: looks like 'fd:' is now changed to '08:' [not sure if its is universally
> true for all installs..]

fd: is not 08: all the time - it is 09: on other systems and, I suspect it will change so I changed the script to look for '/' and then exclude items which are obviously not valid (things starting with '00:')

OK,going to the appropriate directory and running the program through python (and not touching the computer until it finished) told me that my flash plugin and firefox need restarting, after about two minutes.  Running it again, without invoking python, got the same results, a tad faster.  We seem to have a winner, here.  Thanx for the prompt response.

2 minutes? That is a long time for this to run.

Can you run:

time python ./needs-restarting.py

and include the output

it shouldn't be 2 minutes.

That should only happen if it has to download metadata.

The long delay was only the first time; it works quite quickly now.  Your thought about it needing to download metadata the first time was probably all it was.

For further checking, I just got home from house sitting and tried the new version on my desktop, twice:

[joe@khorlia Download]$ time ./needs-restarting
2099 : /usr/lib/firefox-3.6/firefox 

real	4m8.398s
user	0m52.144s
sys	0m9.700s
[joe@khorlia Download]$ time ./needs-restarting
2099 : /usr/lib/firefox-3.6/firefox 

real	0m18.827s
user	0m8.421s
sys	0m1.855s
[joe@khorlia Download]$ 

It's quite possible that the difference was downloading metadata.  Again, thanx for getting this corrected.

This message is a notice that Fedora 15 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 15. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. At this time, all open bugs with a Fedora 'version'
of '15' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that
we were unable to fix it before Fedora 15 reached end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora, you are encouraged to click on
"Clone This Bug" (top right of this page) and open it against that
version of Fedora.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

The process we are following is described here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping