Bug 733956
Summary: | options of curl-config should be compatible with upstream | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Martijn Faassen <faassen> | ||||
Component: | curl | Assignee: | Kamil Dudka <kdudka> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 15 | CC: | faassen, jnovy, kdudka, paul | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | curl-7.21.7-5.fc16 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-09-26 23:23:35 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Martijn Faassen
2011-08-28 21:47:10 UTC
The option --static-libs is being removed by the multilib patch during the build, which I believe is intentionally (I am not the author of the patch). Hence, I would just remove the option from the man page, too. Is such a fix acceptable for you? No, that won't work for me; pycurl needs --static-libs in its setup.py procedure and my build process execute that setup.py. I'm not the author of pycurl but it's reasonable for the pycurl authors to assume that --static-libs is an existing option as it's documented. (I realize pycurl is in Fedora too, but I am using a portal python build environment) I don't know what the reason is to remove the --static-libs option, but it seems incompatible to me to be removing documented options. I'd rather have the option always be there and return nothing if invoked, or something like that. But I guess to make the correct decision we'd need to know what the reason is behind this removal. The option not being in the man page would probably make things even *more* mysterious when things fail, not less. Reintroducing --static-libs with empty output sounds like a good idea. It was removed in curl-7.18.1-1.fc9: http://pkgs.fedoraproject.org/gitweb/?p=curl.git;a=commitdiff;h=43a8fac I will ask Jindra for some details... Just consulted it with Kamil. Maybe leaving the dummy --static-libs in package config would help here. But it's definitely a good idea to mention it in man page. Enabling static link for real is no-go for libcurl IMO. Created attachment 520386 [details] the updated multilib patch It should address both comment #2 and comment #4 . Thanks! (I noticed a typo in my comment; so just for clarity: I meant I'm using a *portable* build environment for Python) (In reply to comment #1) > The option --static-libs is being removed by the multilib patch during the > build, which I believe is intentionally (I am not the author of the patch). > Hence, I would just remove the option from the man page, too. Is such a fix > acceptable for you? Historical note: the --static-libs option was removed from curl-config during the merge review because (a) there were no static libs anyway, and (b) the code implementing the option referenced libdir and hence caused a multilib conflict (Kamil's updated patch does not suffer from this problem). See: https://bugzilla.redhat.com/show_bug.cgi?id=225671#c18 Fedora's python-pycurl package contains a trivial patch to work around the missing option: http://pkgs.fedoraproject.org/gitweb/?p=python-pycurl.git;a=blob;f=python-pycurl-no-static-libs.patch fixed in curl-7.22.0-1.fc17 curl-7.21.3-12.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/curl-7.21.3-12.fc15 curl-7.21.7-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/curl-7.21.7-5.fc16 Package curl-7.21.7-5.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing curl-7.21.7-5.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/curl-7.21.7-5.fc16 then log in and leave karma (feedback). curl-7.21.3-12.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. curl-7.21.7-5.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |