Bug 734014
| Summary: | Review Request: nafees-pakistani-web-naskh-fonts nafees-pakistani-web-naskh-fonts for writing Urdu | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | anish <apatil> | ||||||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | notting, package-review, panemade, petersen | ||||||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | nafees-pakistani-web-naskh-fonts-2.0-2.fc16 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2012-01-07 23:08:41 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
anish
2011-08-29 07:44:35 UTC
Can you please provide SRPM download link? You have added binary rpm url above. Thanks Parag for review. I have added source rpm to SRPM URL: https://github.com/gnuman/nafees-pakistani-web-naskh-fonts/blob/master/nafees-pakistani-web-naskh-fonts-2.0-1.fc15.src.rpm Created attachment 521432 [details]
spec cleanup
This patch will fix following things
1) rpmlint warning
nafees-pakistani-web-naskh-fonts.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 4)
2) I think its good to copy individual source files in builddir
3) newer packaging guidelines suggest
a) buildroot not needed
b) removal of buildroot in %install
Created attachment 522264 [details]
this is srpm for pakistani-web naksh font
attached source rpm due to issues with github
Created attachment 522265 [details]
this is spec file for pakistani-web naksh font
Due to issues with github , I am attaching the spec file
Thanks parag for your review comments I have incorporated changes suggested by you. Please find the SPEC file and SOURCE rpm attached + koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3338229 + rest looks ok as per packaging guidelines. APPROVED. New Package SCM Request ======================= Package Name: nafees-pakistani-web-naskh-fonts Short Description: Nafees pakistani web naskh font for writing Urdu Owners: anishpatil Branches: f16,f17 InitialCC: apatil Git done (by process-git-requests). Removed incorrect branch and InitialCC values. Thanks Jon for correction and GIT nafees-pakistani-web-naskh-fonts-2.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/nafees-pakistani-web-naskh-fonts-2.0-2.fc16 Package nafees-pakistani-web-naskh-fonts-2.0-2.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nafees-pakistani-web-naskh-fonts-2.0-2.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-17261/nafees-pakistani-web-naskh-fonts-2.0-2.fc16 then log in and leave karma (feedback). nafees-pakistani-web-naskh-fonts-2.0-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |