Bug 734490

Summary: AS7 plugin: resource config: 'Module Name' member props of 'Installed Extensions' map should be read-only
Product: [Other] RHQ Project Reporter: Ian Springer <ian.springer>
Component: PluginsAssignee: Mike Thompson <mithomps>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0.1CC: ccrouch, hrupp, mithomps
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.5.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-04 03:48:12 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 678340, 707223, 820425    
Attachments:
Description Flags
Screenshot
none
Read only fixed none

Description Ian Springer 2011-08-30 11:01:22 EDT
I'm pretty sure we don't want users to be able to edit the module names. The fix should be to add the readOnly="true" attribute to the member prop def, i.e.:

            <c:group name="children:extension" displayName="Installed extensions">

                <c:list-property name="*" displayName="Installed extensions" readOnly="true" required="false">
                    <c:map-property name="*" displayName="Name" readOnly="true">
                        <c:simple-property name="module" displayName="Module name" readOnly="true"/>
                    </c:map-property>
                </c:list-property>
            </c:group>


Note, the readOnly="true" attribute on the map property itself prevents member props from being added or deleted, but does not prevent existing member props from being updated.
Comment 1 Heiko W. Rupp 2012-01-18 05:53:58 EST
This is  a UI bug and not as7-specific -- see also BUG 782506
Comment 2 Ian Springer 2012-03-26 13:59:48 EDT
Heiko, couldn't this property be implemented as a list-of-simples, rather than a list-of-maps? Or was there a reason you made it a list of maps?
Comment 3 Heiko W. Rupp 2012-04-11 08:53:01 EDT
This does not change anything -- the row still has the "can be edited" pencil even if the entry can not be modified in the details view.

      <c:group name="children:extension:module" displayName="Installed extensions" hiddenByDefault="true">
        <c:list-property name="extensions" displayName="Installed extensions" readOnly="true" required="false">
            <c:simple-property name="module" displayName="Module name" readOnly="true"/>
        </c:list-property>
      </c:group>
    </resource-configuration>

See attached screenshot
Comment 4 Heiko W. Rupp 2012-04-11 08:53:39 EDT
Created attachment 576764 [details]
Screenshot
Comment 5 Charles Crouch 2012-04-12 20:22:54 EDT
Lowering priority, this is not a blocker for rhq4.4
Comment 6 Mike Thompson 2012-07-02 18:29:03 EDT
Created attachment 595821 [details]
Read only fixed
Comment 7 Mike Thompson 2012-07-02 18:33:38 EDT
Fixed by Master Commit Id: 87f63d5522059ca035c0c1d1377aba569e552b22

This read only plugin configuration was being was not being rendered by the gui.

This fix also fixed related BZ 782506 - config editor shows edit/pencil icon for a map that does not contain any editable member props.

I have attached of screenshot of what it looks like now.
Comment 9 Heiko W. Rupp 2013-09-04 03:48:12 EDT
Bulk closing of some old issues