| Summary: | kickstart repo --cost is ignored | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mads Kiilerich <mads> |
| Component: | livecd-tools | Assignee: | Brian Lane <bcl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 16 | CC: | adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | livecd-tools-17.11-1.fc17 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-05-08 04:32:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mads Kiilerich
2011-09-01 11:23:12 UTC
Proof of concept fix - entirely in python-imgcreate:
--- kickstart.py 2011-09-01 13:39:52.486228328 +0200
+++ /usr/lib/python2.7/site-packages/imgcreate/kickstart.py
@@ -511,7 +511,7 @@
if repos.has_key(repo.name):
logging.warn("Overriding already specified repo %s" %(repo.name,))
- repos[repo.name] = (repo.name, baseurl, mirrorlist, proxy, inc, exc)
+ repos[repo.name] = (repo.name, baseurl, mirrorlist, proxy, inc, exc, repo.cost)
return repos.values()
--- creator.py 2011-09-01 13:32:40.030261984 +0200
+++ /usr/lib/python2.7/site-packages/imgcreate/creator.py
@@ -612,7 +612,7 @@
ayum.setup(yum_conf, self._instroot)
for repo in kickstart.get_repos(self.ks, repo_urls):
- (name, baseurl, mirrorlist, proxy, inc, exc) = repo
+ (name, baseurl, mirrorlist, proxy, inc, exc, cost) = repo
yr = ayum.addRepository(name, baseurl, mirrorlist)
if inc:
@@ -621,6 +621,8 @@
yr.exclude = exc
if proxy:
yr.proxy = proxy
+ if not cost is None:
+ yr.cost = cost
if kickstart.exclude_docs(self.ks):
rpm.addMacro("_excludedocs", "1")
Is this also a problem with anaconda? Or just livecd's? I don't know. I "never" use anaconda with package installation - I "always" install by letting anaconda resize a live image. A quick greb for \.cost in /usr/lib/python2.7/site-packages/pyanaconda/yuminstall.py indicates that it do have the right plumbing in place. (It do however seem like repos with cost 0 will cause problems - even though that would be the most obvious cost to assign to a local file:// repo ...) livecd-tools-16.12-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/livecd-tools-16.12-1.fc16 livecd-tools-17.8-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/livecd-tools-17.8-1.fc17 Package livecd-tools-16.12-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing livecd-tools-16.12-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-6062/livecd-tools-16.12-1.fc16 then log in and leave karma (feedback). livecd-tools-17.9-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/livecd-tools-17.9-1.fc17 livecd-tools-16.13-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/livecd-tools-16.13-1.fc16 livecd-tools-17.10-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/livecd-tools-17.10-1.fc17 livecd-tools-16.15-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/livecd-tools-16.15-1.fc16 livecd-tools-17.11-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/livecd-tools-17.11-1.fc17 livecd-tools-17.11-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |