Bug 735108

I guess, this regards also to f15 and f16 packages.

Hi,

We can't ship the upstream syslog-ng.service file as we need to override the default syslog-ng pid file. This is needed to avoid conflicts between the several syslog daemons available: by having all (rsyslog, syslog-ng and sysklogd) using the same pid file, we can ship the same logrotate file and thus avoiding file conflicts.

/jpo

That's why I suggested using it but patching it as necessary. Keeping the difference to upstream minimal does not have to mean to keep them at zero.

Enforcing the pid file path looks like a good enough reason to patch the unit file. But why do you add the configurability using /etc/sysconfig/syslog-ng?:

SYSLOGNG_OPTIONS="-F -p /var/run/syslogd.pid"

Having the sysconfig file just creates the impression that the user is free to change the pid file path. Why would he want to do that? Especially since changing it would break the assumption of the logrotate script. This looks like an option that the user should not be encouraged to touch.

The case for keeping the "-F" option directly in the unit file is even stronger. If the user deletes it from SYSLOGNG_OPTIONS, the service will break.

/etc/sysconfig/syslog-ng should not exist. The options that are there in the default setup should be in the unit file directly.

(In reply to comment #4)
> Enforcing the pid file path looks like a good enough reason to patch the unit
> file. But why do you add the configurability using /etc/sysconfig/syslog-ng?:

Old habits (and also having to support RHEL systems).

> SYSLOGNG_OPTIONS="-F -p /var/run/syslogd.pid"
> 
> Having the sysconfig file just creates the impression that the user is free to
> change the pid file path. Why would he want to do that? Especially since
> changing it would break the assumption of the logrotate script. This looks like
> an option that the user should not be encouraged to touch.

Yes, not encouraged to touch if wants to have both the rsyslog and the syslog-ng (and even the olg sysklogd) rpms installed. But if he knows what is doing he can even have several syslog daemons active at the same system; and it is a lot easier if he removes rsyslog after installing syslog-ng: then he can do whatever he likes to the configuration files.

> 
> The case for keeping the "-F" option directly in the unit file is even
> stronger. If the user deletes it from SYSLOGNG_OPTIONS, the service will break.
> 
> /etc/sysconfig/syslog-ng should not exist. The options that are there in the
> default setup should be in the unit file directly.

I agree with you: there is no point in keeping the sysconfig file around in systemd systems.  I will to release a new syslog-ng SRPM without the sysconfig file.

/jpo

New rawhide release:

 * syslog-ng-3.2.5-3.fc17
   http://koji.fedoraproject.org/koji/buildinfo?buildID=278885

Patch being applied against the upstream service file (for Fedora >= 17):

----------
--- syslog-ng-3.2.5/contrib/systemd/syslog-ng.service	2011-10-23 07:48:18.000000000 +0100
+++ syslog-ng-3.2.5-modified/contrib/systemd/syslog-ng.service	2011-12-15 02:25:38.598337205 +0000
@@ -4,7 +4,7 @@
 [Service]
 Sockets=syslog.socket
 ExecStartPre=/bin/systemctl stop systemd-kmsg-syslogd.service
-ExecStart=/usr/sbin/syslog-ng -F
+ExecStart=/usr/sbin/syslog-ng -F -p /var/run/syslogd.pid
 ExecReload=/bin/kill -HUP $MAINPID
 StandardOutput=null
----------


Current syslog-ng NVR:

 * syslog-ng-3.2.5-14.fc17