Bug 735182

Summary: libreoffice doesn't build with poppler-0.17.3
Product: [Fedora] Fedora Reporter: Marek Kašík <mkasik>
Component: libreofficeAssignee: Caolan McNamara <caolanm>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: caolanm, dtardon, ltinkl
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libreoffice-3.4.3.2-6.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-02 12:21:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 735175    

Description Marek Kašík 2011-09-01 17:42:57 UTC 
Description of problem:
Current version of libreoffice needs poppler's class DCTStream, which is not
present now.


Log snippet:
Entering /builddir/build/BUILD/libreoffice-3.4.3.2/sdext/source/pdfimport/xpdfwrapper
Compiling: sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx
Compiling: sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx
/builddir/build/BUILD/libreoffice-3.4.3.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx: In function 'void pdfi::writeJpeg_(OutputBuffer&, Stream*, bool)':
/builddir/build/BUILD/libreoffice-3.4.3.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:153:13: error: 'DCTStream' was not declared in this scope
/builddir/build/BUILD/libreoffice-3.4.3.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:153:24: error: expected primary-expression before ')' token
/builddir/build/BUILD/libreoffice-3.4.3.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:153:25: error: expected ')' before 'str'


Version-Release number of selected component (if applicable):
libreoffice-3.4.3.2-3


Actual results:
Build fails.


Expected results:
Build succeed.


Additional info:
See the bug #735175 for more info and scratch-build of poppler-0.17.3.
This was introduced by upstream commit "Sanitize headers a big" (mainly by
correction of definition of ENABLE_LIBJPEG - see definition of DCTStream class
in poppler/Stream.h) (see http://cgit.freedesktop.org/poppler/poppler/commit/?id=a8fca630d592941c033ca6a380bf46b6e733a748).
Comment 1 Caolan McNamara 2011-09-02 10:27:37 UTC 
bah
Comment 2 Caolan McNamara 2011-09-02 11:47:24 UTC 
I see that for poppler itself, when its ENABLE_LIBJPEG its own utils include 

#ifdef ENABLE_LIBJPEG
#include "DCTStream.h"
#endif

and regain access to DCTStream, they (like us) use it to call getRawStream.

DCTStream.h however isn't installed into the -devel package, so external apps can't use the same hack as poppler itself
Comment 3 Caolan McNamara 2011-09-02 12:21:52 UTC 
fix checked in for F-16/master
Comment 4 Marek Kašík 2011-09-02 12:28:25 UTC 
Thank you very much.
Comment 5 Fedora Update System 2011-09-07 10:02:08 UTC 
libreoffice-3.4.3.2-6.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libreoffice-3.4.3.2-6.fc16
Comment 6 Fedora Update System 2011-09-09 17:05:41 UTC 
libreoffice-3.4.3.2-6.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.