Bug 735284
| Summary: | RFE : shotwell 0.11.0-1 .spec requires patches to build | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Didier <d.bz-redhat> | ||||||||
| Component: | shotwell | Assignee: | Matthias Clasen <mclasen> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 15 | CC: | amcnabb, belegdol, dgsiegel, mclasen, metherid, michel, nekohayo, nomnex, sjoerd, spoyarek, thomas.moschny | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2012-08-07 17:14:39 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Didier
2011-09-02 07:19:42 UTC
Created attachment 522531 [details]
Patch against shotwell-0.11.1-1 spec file
Also stumbled across specfile issues while trying to recompile. Here's my patch.
It looks like there is a little bug in the patch by Didier. The changed line with the touch command has just a : (colon) added. That should probably be || : Created attachment 528060 [details]
Update to 0.11.3 (diff against current master)
I don't think this patch will help, since shotwell 0.11 doesn't build with the vala version that is in F16 and rawhide. (In reply to comment #4) > I don't think this patch will help, since shotwell 0.11 doesn't build with the > vala version that is in F16 and rawhide. See http://redmine.yorba.org/issues/3760 : this is only about compiler warnings, and with some minor tweaking of the Makefile one can force compiling with vala 0.14. Another option would be a backport of http://redmine.yorba.org/projects/shotwell/repository/revisions/64aec6b035f73de53f2f8300a55e7aac35b7256c which should be possible without much effort. For anyone interested, updated RPMs are here: http://repos.fedorapeople.org/repos/thm/shotwell/ , for F14, F15 and F16. These are built using the first method described above, and are barely tested, use at your own risk. Feedback welcome. (In reply to comment #5) > For anyone interested, updated RPMs are here: > http://repos.fedorapeople.org/repos/thm/shotwell/ , for F14, F15 and F16. These On first sight, runs OK on F15 x64. Thanks ! Confirmed working on F16 x64. Thanks again ! Thomas, your package should not force compiling with Vala 0.14. It causes stuff like http://redmine.yorba.org/issues/4622. (In reply to comment #8) > Thomas, your package should not force compiling with Vala 0.14. It causes stuff > like http://redmine.yorba.org/issues/4622. You are totally right. I just noticed this myself, and will try to build a package with old vala. There are now RPMs built with vala 0.12.1 in my repo, for testing. As always, use on your own risk. The updated shotwell package fixes my issue from comment 9. I noticed that your repo seems to contain a "vala12" package, but the shotwell package doesn't actually seem to depend on it and the app seems to run fine...? (In reply to comment #11) > The updated shotwell package fixes my issue from comment 9. Great, thanks for testing. > I noticed that your repo seems to contain a "vala12" package, but the shotwell > package doesn't actually seem to depend on it and the app seems to run fine...? That is the compiler I built it with. It is not needed at runtime, but in my repo for the sake of completeness. Not sure how that component change in bugzilla happened... 1. shotwell-0.12.0-0.1.20111117gitcf087489ea.fc17.src.rpm (http://koji.fedoraproject.org/koji/buildinfo?buildID=274544) recompiles fine on F16 x64 ; 2. After compiling vala 0.15 (http://koji.fedoraproject.org/koji/buildinfo?buildID=291659) for F16 x64, shotwell 0.11.91 (https://launchpad.net/ubuntu/precise/+source/shotwell/0.11.91-0ubuntu2/+files/shotwell_0.11.91.orig.tar.gz) compiles and appears to run fine on F16 x64. for (2.), I used the .spec from (1.) and shoe-horned the "rm" in the %install clause to include 'icon-theme.cache' : "rm -rf 16x16 24x24 scalable icon-theme.cache" Sure, but neither git Version cf087489ea nor 0.11.91 are released stable versions. This message is a notice that Fedora 15 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 15. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At this time, all open bugs with a Fedora 'version' of '15' have been closed as WONTFIX. (Please note: Our normal process is to give advanced warning of this occurring, but we forgot to do that. A thousand apologies.) Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, feel free to reopen this bug and simply change the 'version' to a later Fedora version. Bug Reporter: Thank you for reporting this issue and we are sorry that we were unable to fix it before Fedora 15 reached end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" (top right of this page) and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping |