Bug 735997

Summary:	legacy code cleanup .
Product:	[Retired] oVirt	Reporter:	Oded Ramraz <oramraz>
Component:	ovirt-engine-core	Assignee:	lpeer <lpeer>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	unspecified	CC:	iheim, jhenner, lpeer, oramraz, Rhev-m-bugs, yeylon, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra virt
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-11 06:42:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Oded Ramraz 2011-09-06 11:43:36 UTC

Description of problem:

I noticed in our automatic tests Cobertura ( coverage tool )  report that there are many non reachable / usable classes in the Backend code.

Few examples:
class TimeLeaseVmPoolMapDAOHibernate , GetAllVmPoolsAttachedToUserQuery , DetachUserFromTimeLeasedPoolCommand , GetTemplateMessagesQuery  , GetVmCustomPropertiesQuery , VmQuery ( it is a empty method ) .

There are plenty of more examples. 

BTW , although this is a coding issue i can verify it using the Cobertura tool . 

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Oded Ramraz 2011-10-25 13:35:24 UTC

There is also future code which is not in use such as the hibernate code .

Comment 3 Itamar Heim 2012-12-11 06:42:32 UTC

Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.