| Summary: | Review Request: apache-parent | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andy Grimm <agrimm> |
| Component: | Package Review | Assignee: | Stanislav Ochotnicky <sochotni> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 16 | CC: | jgoulding, notting, package-review, sochotni |
| Target Milestone: | --- | Flags: | sochotni:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | apache-parent-10-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-09-30 19:08:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Andy Grimm
2011-09-06 15:09:33 UTC
I'll do the shortened version because the spec is really small and clean. Licensing is OK (ASL 2.0) rpmlint is completely clean. Basically everything is A-OK. I just have 2 suggestions:
1. You can put the url directly into Source0. It would be a problem if there were more pom.xml files, but that's not the case so...
2. It's usually better to be specific i.e. have %{_mavendepmapfragdir}/%{name} instead of * (same for the pom line)
These two non-issues are really small and basically up to you if you want to handle them. Package is APPROVED. I'll remove common-poms apache-parent once this package is in...
New Package SCM Request ======================= Package Name: apache-parent Short Description: Parent pom file for Apache projects Owners: arg Branches: f16 InitialCC: Git done (by process-git-requests). (In reply to comment #1) > I'll do the shortened version because the spec is really small and clean. > Licensing is OK (ASL 2.0) rpmlint is completely clean. Basically everything is > A-OK. I just have 2 suggestions: > > 1. You can put the url directly into Source0. It would be a problem if there > were more pom.xml files, but that's not the case so... The reason I did not do this is that when you install the SRPM into your personal "rpmbuild" environment, you end up with a file called "pom.xml" in SOURCES ... and when I'm packaging lots of maven-based packages concurrently, this doesn't work out well. I suppose that if I switch to using git/fedpkg for all of my development, this is no longer an issue. > 2. It's usually better to be specific i.e. have %{_mavendepmapfragdir}/%{name} > instead of * (same for the pom line) This makes sense, though it would be good to see it in the guidelines if we prefer not to have people using globs. > These two non-issues are really small and basically up to you if you want to > handle them. Package is APPROVED. I'll remove common-poms apache-parent once > this package is in... apache-parent-10-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/apache-parent-10-2.fc16 apache-parent-10-2.fc16 has been pushed to the Fedora 16 testing repository. apache-parent-10-2.fc16 has been pushed to the Fedora 16 stable repository. |