Bug 736422

Summary:	VDSM - should be able to recover from malformed message from rhev-agent
Product:	Red Hat Enterprise Linux 6	Reporter:	Barak <bazulay>
Component:	vdsm	Assignee:	Gal Hammer <ghammer>
Status:	CLOSED ERRATA	QA Contact:	Jakub Libosvar <jlibosva>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.2	CC:	abaron, bazulay, dnaori, iheim, ilvovsky, ykaul
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vdsm-4.9-101	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 07:28:15 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	736426

Description Barak 2011-09-07 16:33:47 UTC

Description of problem:

Using the current VDSM <-> rhev-agent protocol, VDSM can't recover from a malformed message, and the channel between the VDSM to the rhev-agent becomes useless.

This protocol's origin is in the old hypercall device (not upstream) on rhel 5.X.

On RHEL 6 we moved to vioserial device.

On one of the vioserial discussions, it was brought up that the vioserial does not guarantee that the message will reach it's destiny intact (this was especially emphasized in the last round of discussions regarding s3/s4 support).



In order to be able to recover the protocol must be altered to identify the malformed message and drop it.

Since the VDSM <-> rhev-agent API is stateless dropping a single (malformed) message does not break anything.

Comment 8 Dan Kenigsberg 2011-09-15 11:00:57 UTC

*** Bug 738355 has been marked as a duplicate of this bug. ***

Comment 10 Jakub Libosvar 2011-09-26 08:31:29 UTC

Verified between agent rhev-agent-2.3.14-1.el6 and vdsm-4.9-104.el6.x86_64

Comment 11 errata-xmlrpc 2011-12-06 07:28:15 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1782.html