Bug 736603

Summary:	[libvirt][domblkinfo] libvirtd crash on domblkinfo.
Product:	Red Hat Enterprise Linux 6	Reporter:	David Naori <dnaori>
Component:	libvirt	Assignee:	Michal Privoznik <mprivozn>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	6.1	CC:	abaron, danken, ddumas, dnaori, dyuan, eblake, mgoldboi, mzhan, nzhang, rwu, syeghiay, veillard, ykaul, yupzhang
Target Milestone:	beta	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-0.9.4-11.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 11:28:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	638510
Bug Blocks:	743047

Description David Naori 2011-09-08 08:22:15 UTC

Description of problem:
libvirtd crash on domblkinfo. 

# pgrep libvirtd 19191
# virsh -r domblkinfo 1 vda
error: End of file while reading data: Input/output error
# pgrep libvirtd 20472

No core-dump, nothing in logs.

Version-Release number of selected component (if applicable):
libvirt-0.9.4-10.el6.x86_64


How reproducible:
100%

Comment 2 David Naori 2011-09-08 08:24:21 UTC

Worked on libvirt-0.9.4-7.el6.x86_64

Comment 3 Eric Blake 2011-09-08 08:32:35 UTC

I suspect my snapshot patches may be involved; in particular, my guess is this upstream commit:

commit 89b6284fd94ce5b13ee6b002f9167f5d9074aa7a
Author: Eric Blake <eblake>
Date:   Fri Aug 19 20:38:36 2011 -0600

    snapshot: also support disks by path
    
    I got confused when 'virsh domblkinfo dom disk' required the
    path to a disk (which can be ambiguous, since a single file
    can back multiple disks), rather than the unambiguous target
    device name that I was using in disk snapshots.  So, in true
    developer fashion, I went for the best of both worlds - all
    interfaces that operate on a disk (aka block) now accept
    either the target name or the unambiguous path to the backing
    file used by the disk.

Comment 4 Daniel Veillard 2011-09-08 08:37:18 UTC

yup seems to be an uninitialized disk variable should be easy to get fixed

Daniel

Comment 5 Eric Blake 2011-09-08 09:13:38 UTC

Upstream patch proposed:
https://www.redhat.com/archives/libvir-list/2011-September/msg00379.html

Comment 6 Michal Privoznik 2011-09-08 10:03:28 UTC

Moving to POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-September/msg00286.html

Comment 10 yuping zhang 2011-09-09 02:55:20 UTC

Reproduce this issue with libvirt-0.9.4-10.el6.x86_64.
Verified this issue with:
libvirt-0.9.4-11.el6.x86_64
kernel-2.6.32-193.el6.x86_64
qemu-kvm-0.12.1.2-2.185.el6.x86_64

# pgrep libvirtd
27271
# virsh -r domblkinfo 15 vda
Capacity:       8589934592
Allocation:     8589938688
Physical:       8589938688
# pgrep libvirtd
27271

So change the status to VERIFIED.

Comment 11 errata-xmlrpc 2011-12-06 11:28:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html