Bug 736994

I'll take this one.

* Descriptive filenames
  - It would be fine if the Source1 and Source2 files could have more descriptive
    names, such as %{gemname}-%{version}-tests-upstream.tgz and 
    %{gemname}-%{version}-tests-patch.tgz

* Make sure that the test suite is really using the C extension
  - There is recorded following notice in buildlog, which makes me wonder if the
    test suite is really doing what is supposed to do:

    "Notice: C extension not loaded. This is required for optimum MongoDB Ruby
     driver performance."

* pushd should be paired with popd
  - It is considered good habit I would say

* Test cleanup
  - The test suite is extracted in temporary directory, but it is not later
    removed.

* Files not required for runtime should be moved into -doc subpackage
  - Please move "%{geminstdir}/Rakefile" and "%{geminstdir}/bson_ext.gemspec" 
    into -doc subpackage according to [1]

[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

There seems to be an issue with tests on i386 architecture:

  1) Error:
test_from_time_unique(ObjectIdTest):
RangeError: bignum too big to convert into `long'
   
/usr/lib/ruby/gems/1.8/gems/bson-1.3.1/lib/../lib/bson/types/object_id.rb:170:in
`at'
   
/usr/lib/ruby/gems/1.8/gems/bson-1.3.1/lib/../lib/bson/types/object_id.rb:170:in
`generation_time'
    ./test/bson/object_id_test.rb:137:in `test_from_time_unique'

It seems that the long on i386 is not long enough for the particular used
bignum, since on x86_64 everything works fine.

I reported the bug here:
https://jira.mongodb.org/browse/RUBY-327

I've fixed the issues and updated to the last upstream version, which solved the problem mentioned in Comment 3.
SPEC: http://bkabrda.fedorapeople.org/bson_ext/rubygem-bson_ext.spec
SRPM: http://bkabrda.fedorapeople.org/bson_ext/rubygem-bson_ext-1.4.0-1.fc15.src.rpm

* Incoherent version in changelog
  - From rpmlint outpu: rubygem-bson_ext.i686: W: incoherent-version-in-changelog
    1.3.1-3 ['1.4.0-1.fc17', '1.4.0-1']
  - You forgot to update the changelog version accordingly.

* The test cleanup should be done in the same section as the test preparation
  - Since the test are unpacked required just in %check section, I would suggest
    to clean them in the same section
  - Another alternative would be to unpack the using %setup macro, but I am not
    aware of any other package which is prepared this way. It might be worth of
    investigation

Please fix this nits before import. Otherwise the package looks good => APPROVED

New Package SCM Request
=======================
Package Name: rubygem-bson_ext
Short Description: C extensions for Ruby BSON
Owners: vondruch
Branches:
InitialCC:

Git done (by process-git-requests).

Package Change Request
======================
Package Name: rubygem-bson_ext
New Branches: f16
Owners: vondruch jknife

Git done (by process-git-requests).