Bug 737159
| Summary: | jboss-cache plugin: several required resource config props are not being set by the plugin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Ian Springer <ian.springer> | ||||
| Component: | Plugins | Assignee: | Nobody <nobody> | ||||
| Status: | NEW --- | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.1 | CC: | hrupp, jshaughn | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 625146 | ||||||
| Bug Blocks: | 678340, 745494 | ||||||
| Attachments: |
|
||||||
|
Description
Ian Springer
2011-09-09 19:05:34 UTC
Created attachment 530111 [details]
patch that fixes this issue, as well as several other bugs in the jboss-cache resource-config load/update code
[master 5ee3245] (http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commitdiff;h=5ee3245) fixes this as well as two other major issues in the jboss-cache resource config update: 1) 'attribute' elements that did not correspond to a resource config prop were excised from the file, badly corrupting it 2) for resource config props with null values, the 'attribute' elements were written out as: <attribute name="foo" /> (i.e. not containing any text content), which is incorrect; instead they should not be written out at all. and several minor issues: 3) there were several other config props that should have been optional 4) duplicate "<depends>jboss:service=TransactionManager</depends>" lines added on every update 5) in config load, props were added to the config for every 'attribute' element found in the xml file, even ones that did not have corresponding prop defs in the config def; this resulted in superfluous props being persisted to the DB, which would not even be displayed in the GUI's config editor; it also indirectly resulted in major issue 1) above QE: Note, these fixes can be tested using any JBoss AS 4.2.x instance running the 'all' config. As part of testing, after making various config updates, restart the AS instance and make sure there are no jboss-cache related errors during startup. reducing priority for qe verification as this is not in jon 3 branch QA failed. By the looks of it there are more attributes that we should mark as optional. I found these (but don't claim the list to be exhaustive): * TransactionManagerLookupClass (http://docs.jboss.org/jbossas/jboss4guide/r4/html/jbosscache.chapt.html#jbosscache-cache) * InitialStateRetrievalTimeout - didn't find documentation suggesting it's optional but a config w/o this parameter doesn't cause any errors in the logs. Lukas, assigning this ips legacy bz to you given the above comments. |