Bug 737183
Summary: | Provide native systemd service file | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jóhann B. Guðmundsson <johannbg> | ||||||||||
Component: | git | Assignee: | Chris Wright <chrisw> | ||||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
Severity: | unspecified | Docs Contact: | |||||||||||
Priority: | unspecified | ||||||||||||
Version: | 19 | CC: | bkearney, bochecha, chrisw, dhoward, johannbg, ovasik, tcallawa, tmz, zbyszek | ||||||||||
Target Milestone: | --- | Keywords: | Reopened | ||||||||||
Target Release: | --- | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Whiteboard: | |||||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
Doc Text: | Story Points: | --- | |||||||||||
Clone Of: | Environment: | ||||||||||||
Last Closed: | 2015-01-06 20:34:36 UTC | Type: | --- | ||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||
Documentation: | --- | CRM: | |||||||||||
Verified Versions: | Category: | --- | |||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
Embargoed: | |||||||||||||
Bug Depends On: | |||||||||||||
Bug Blocks: | 713562 | ||||||||||||
Attachments: |
|
Description
Jóhann B. Guðmundsson
2011-09-09 19:47:48 UTC
Created attachment 522394 [details]
git socket
Created attachment 522395 [details]
git service
Passes simple telnet test... [root@valhalla system]# systemctl start git.socket [root@valhalla system]# systemctl status git.socket git.socket - Git Activation Socket Loaded: loaded (/lib/systemd/system/git.socket) Active: active (listening) since Fri, 09 Sep 2011 19:45:07 +0000; 10s ago Accepted: 0; Connected: 0 CGroup: name=systemd:/system/git.socket [root@valhalla system]# telnet localhost 9418 Trying ::1... Connected to localhost. Escape character is '^]'. And note there is still a (tight) window to have this in F16 Created attachment 522535 [details]
git service
Once package and shipped your package should no longer have to depend on xinetd https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd So, I'm using something very similar here, with the difference that I added "Group=nobody". Quite happy about it, it works nicely. Johann, what's the point of the "After=local-fs.target"? Isn't that part of the default dependencies? Chris, any plan to push that to Fedora 18? :) (In reply to comment #6) > So, I'm using something very similar here, with the difference that I added > "Group=nobody". Quite happy about it, it works nicely. > > Johann, what's the point of the "After=local-fs.target"? Isn't that part of > the default dependencies?. There are several things that are default now but weren't not hence the unit clean-up process [1] to get things in sync with upstream. 1. http://fedoraproject.org/wiki/Features/Systemd-unit-cleanup This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 Created attachment 740488 [details]
Updated git.service
Could this happen before Fedora 19? git-1.8.2.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/git-1.8.2.1-2.fc19 Thanks Tom. Just for the record, we'll eventually need to redo this to take older releases into account. We've tried hard to make it easy to build git for EL releases from the current spec files. I've talked to a lot of folks that appreciate this ability (and none who have ever cared about systemd, coincidentally). :) Package git-1.8.2.1-2.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing git-1.8.2.1-2.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-7189/git-1.8.2.1-2.fc19 then log in and leave karma (feedback). After upgrading from F18 to F19, and enabling git.socket, I get the following error when trying to connect from another host. systemd[1]: git.socket failed to queue service startup job (Maybe the service file is missing or not a template unit?): Invalid argument systemd[1]: Unit git.socket entered failed state. git-daemon-1.8.3.1-1.fc19.x86_64 (In reply to Anthony Messina from comment #14) > After upgrading from F18 to F19, and enabling git.socket, I get the > following error when trying to connect from another host. > > systemd[1]: git.socket failed to queue service startup job (Maybe the > service file is missing or not a template unit?): Invalid argument > systemd[1]: Unit git.socket entered failed state. > > git-daemon-1.8.3.1-1.fc19.x86_64 I aplogize, I see that Bug 980574 is filed. Given that I have left the project and a new individual may or may not continue with systemd integration in the project by submitting new feature following whatever demands FPC and FESCo might have and thus new units in the process I'm closing this and all remaining bugs I had submitted for this particular feature as WONTFIX |