Bug 737203

This will prevent bootloader installation on x86 BIOS systems that have other OS installed at the very least. It might even break installs that have no other installed OS.

I tested TC1 with which installed to make os-prober work, installing alongside Windows, and it worked...so has this script changed in TC2?

I'll do some tests and post results, anyway.

(In reply to comment #2)
> I tested TC1 with which installed to make os-prober work, installing alongside
> Windows, and it worked...so has this script changed in TC2?
> 
> I'll do some tests and post results, anyway.

You need to have an OSX partition, I think.

Discussed during the 2011-09-12 Fedora QA meeting. We agreed to defer a decision on the blocker status of this bug due to lack of information.

Under which situations would users hit this bug (OSX partitions, Windows partitions etc.)? Can someone (or more than 1 person) hitting this bug describe the partition layout that they're using?

    macosx)
      OSXUUID="`grub-probe --target=fs_uuid --device ${DEVICE} 2> /dev/null`"
      osx_entry xnu_kernel 32
      osx_entry xnu_kernel64 64
    ;;  

Given the code, it will fail if there are any detected OSX partitions (grub-probe fails because it doesn't exist, exit code is carried to the end of the script, script thus fails, then grub2-mkconfig is failing)

Created attachment 522740 [details]
fix the bug

updating summary.

I don't think this quite makes Beta blocker status - we require installation alongside Windows to work at Final, but we have no such criterion for OS X at Beta or Final. I'd vote -1 blocker +1 NTH for Beta  or Final, I think.

We don't have another blocker review till Friday but we need to decide on blocker status of all uncertain bugs by tomorrow, so can people please vote here?

+1 to NTH. +1 to Final blocker

+1 NTH, -1 blocker (afaik we don't have a criterion for multi OS except recently for Windows).

I'm also -1 blocker +1 NTH on this. We don't have any requirements for installing alongside OSX and I can't see blocking release for this.

Total at the moment: -2 blocker, +4 NTH.

I'd like to see -3 blocker before rejecting it, but we have enough to accept as NTH.

-1 blocker, +1 NTH, but recommend modify criteria such that install alongside *any* other OS be required in the future.

er, really? Plan 9? ReactOS? My Little Pony OS?

I could see adding OS X to the list, but 'any other OS' is a rather large can of worms.

Hey, what's wrong with Little Pony OS?

Anyway, point taken.

Votes went up to -3 for blocker, moving to rejected.

Adding OS X to the list seems a bit odd to me since we explicitly exclude apple
machines from the EFI criterion. We would end up saying "Fedora has to be able
to co-exist with OS X when installed but we don't care so much if the installer
actually boots and runs"

That just seems a little inconsistent to me.

john: Don't...don't look at my user agent string!

This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

I had the same issue. The patch fixed it.

sigh, I kind of expected this would get fixed for final. pjones, can you fix it now?



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

sooo long discussing instead of releasing a 1 character fix...
SAD.

*** Bug 752279 has been marked as a duplicate of this bug. ***

simone: the discussion was a separate issue: whether the bug is a blocker or not is an important question to do with the release cycle. the bug could still have been fixed by the maintainer at any time, the blocker discussion simply determines exactly when it would have got pulled into the release.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

*** Bug 757299 has been marked as a duplicate of this bug. ***

(In reply to comment #6)
> Created attachment 522740 [details]
> fix the bug

I believe the fix grub2-probe should be ${grub_probe} instead rather than hard coding it as grub2-probe, as there is code early in grub2-mkconfig that allows for the proper substitution.

Chris: yeah, I know. I already fixed it the correct way, it's building for Rawhide ATM.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

I've committed a fix for this and submitted a build for Rawhide, it's waiting on the build server outage. I also submitted the fix upstream:

https://savannah.gnu.org/bugs/index.php?35018

I guess I'll also submit the fix as an F16 update so you can at least do a net install of F16.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

grubby-8.3-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/grubby-8.3-2.fc16

grub2-1.99-13.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/grub2-1.99-13.fc16

Package grub2-1.99-13.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing grub2-1.99-13.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-16975/grub2-1.99-13.fc16
then log in and leave karma (feedback).

worksforme

grub2-1.99-13.fc16 now correctly produces a grub.cfg (from grub.cfg.new) when manually using grub2-mkconfig -o /boot/grub2/grub.cfg.

Resulting grub.cfg on a system containing Mac OS X 10.7.2 (current), Windows Vista, and Fedora 16,  produces the expected entries for all of them. Previously grub.cfg was not created, and grub.cfg.new was truncated at the 30_os-prober header resulting in only Fedora entries.

Looks much better, but I now see this error:

/sbin/grub2-probe: error: no such disk

... in this output:

+ echo '### BEGIN /etc/grub.d/30_os-prober ###'
+ /etc/grub.d/30_os-prober
Found Mac OS X on /dev/sda2
Found Windows 7 (loader) on /dev/sda4
Found Fedora release 13 (Goddard) on /dev/mapper/VolGrp00-f13_root
Found Fedora release 14 (Laughlin) on /dev/mapper/VolGrp00-f14_root
Found Fedora release 15 (Lovelock) on /dev/mapper/VolGrp00-f15_root
/sbin/grub2-probe: error: no such disk.
+ echo '### END /etc/grub.d/30_os-prober ###'
+ for i in '${grub_mkconfig_dir}/*'
+ case "$i" in
+ grub_file_is_not_garbage /etc/grub.d/30_os-prober-orig
+ test -f /etc/grub.d/30_os-prober-orig
+ case "$1" in
+ return 0
+ test -x /etc/grub.d/30_os-prober-orig
+ echo
+ echo '### BEGIN /etc/grub.d/30_os-prober-orig ###'
+ /etc/grub.d/30_os-prober-orig
Found Mac OS X on /dev/sda2


Not sure what it is probing for, but it isn't happy about not finding it.

(In reply to comment #32)
> Looks much better, but I now see this error:
> 
> /sbin/grub2-probe: error: no such disk
> 
> ... in this output:
> 
> + echo '### BEGIN /etc/grub.d/30_os-prober ###'
> + /etc/grub.d/30_os-prober
> Found Mac OS X on /dev/sda2
> Found Windows 7 (loader) on /dev/sda4
> Found Fedora release 13 (Goddard) on /dev/mapper/VolGrp00-f13_root
> Found Fedora release 14 (Laughlin) on /dev/mapper/VolGrp00-f14_root
> Found Fedora release 15 (Lovelock) on /dev/mapper/VolGrp00-f15_root
> /sbin/grub2-probe: error: no such disk.

That is a different error that requires a different fix - please file a new bug report. To debug it insert 'set -x' in /etc/grub.d/30_os-prober instead of running grub2-mkconfig with -x.

> + echo '### BEGIN /etc/grub.d/30_os-prober-orig ###'

You have created a -orig file manually and it is executed just like (almost) any other file in that directory. Please remove it.

grub2-1.99-13.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.