Bug 737228
| Summary: | Review Request: ghc-data-default - A class for types with a default value | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Narasimhan <lakshminaras2002> |
| Component: | Package Review | Assignee: | Jens Petersen <petersen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, haskell-devel, notting, package-review, shakthimaan |
| Target Milestone: | --- | Flags: | petersen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | ghc-data-default-0.5.1-2.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-09 06:54:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 648247, 746557 | ||
|
Description
Narasimhan
2011-09-10 05:39:19 UTC
*** Bug 648246 has been marked as a duplicate of this bug. *** http://koji.fedoraproject.org/koji/taskinfo?taskID=3380247 Looks fine to me. Will post a review soon. Here is the review:
+:ok, NA: not applicable
MUST Items:
[+] MUST: rpmlint output
clean
[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release
2084fb7d26df07eb6b278c5a8ea04d32 data-default-0.3.0.tar.gz
[+] MUST: must successfully compile and build into binary rpms on one main arch
[NA] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec.
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section.
[+] MUST: Packages must not own files or directories already owned by other packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
Package is APPROVED.
Thanks! New Package SCM Request ======================= Package Name: ghc-data-default Short Description: A class for types with a default value Owners: narasim Branches: f14 f15 f16 InitialCC: haskell-sig Git done (by process-git-requests). ghc-data-default-0.3.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-data-default-0.3.0-1.fc16 ghc-data-default-0.3.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-data-default-0.3.0-1.fc14 ghc-data-default-0.3.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ghc-data-default-0.3.0-1.fc15 ghc-data-default-0.3.0-1.fc16 has been pushed to the Fedora 16 testing repository. ghc-data-default-0.3.0-1.fc15 has been pushed to the Fedora 15 stable repository. ghc-data-default-0.3.0-1.fc14 has been pushed to the Fedora 14 stable repository. ghc-data-default-0.3.0-1.fc16 has been pushed to the Fedora 16 stable repository. Package Change Request ====================== Package Name: ghc-data-default New Branches: el6 epel7 Owners: petersen InitialCC: haskell-sig Git done (by process-git-requests). ghc-data-default-0.5.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-data-default-0.5.1-2.el6 ghc-data-default-0.5.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |