Bug 737244

Summary: Provide native systemd service files
Product: [Fedora] Fedora Reporter: Jóhann B. Guðmundsson <johannbg>
Component: rshAssignee: Michal Sekletar <msekleta>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: Francis.Montagnac, ovasik, tcallawa
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-08 14:55:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 713562    
Attachments:
Description Flags
rexec socket
none
rexec service
none
rlogin socket
none
rlogin service
none
rsh socket
none
rsh service none

Description Jóhann B. Guðmundsson 2011-09-10 10:30:00 UTC
Description of problem:

Let's get the ball rolling on this one...

http://fedoraproject.org/wiki/Features/SysVtoSystemd


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jóhann B. Guðmundsson 2011-09-10 10:30:46 UTC
Created attachment 522486 [details]
rexec socket

Comment 2 Jóhann B. Guðmundsson 2011-09-10 10:31:21 UTC
Created attachment 522487 [details]
rexec service

Comment 3 Jóhann B. Guðmundsson 2011-09-10 10:31:58 UTC
Created attachment 522488 [details]
rlogin socket

Comment 4 Jóhann B. Guðmundsson 2011-09-10 10:32:57 UTC
Created attachment 522492 [details]
rlogin service

Comment 5 Jóhann B. Guðmundsson 2011-09-10 10:33:39 UTC
Created attachment 522493 [details]
rsh socket

Comment 6 Jóhann B. Guðmundsson 2011-09-10 10:34:13 UTC
Created attachment 522494 [details]
rsh service

Comment 7 Jóhann B. Guðmundsson 2011-09-10 10:42:54 UTC
Passes simple telnet test and note there is still a (tight) window to have this
in F16

Comment 8 Jóhann B. Guðmundsson 2011-09-12 23:09:59 UTC
Once package and shipped your package should no longer have to depend on xinetd

https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

Comment 9 Fedora Admin XMLRPC Client 2013-04-02 13:25:09 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 10 Fedora End Of Life 2013-04-03 16:25:37 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 11 Fedora Update System 2013-04-15 13:45:32 UTC
rsh-0.17-71.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rsh-0.17-71.fc19

Comment 12 Fedora Update System 2013-04-15 16:20:10 UTC
Package rsh-0.17-71.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing rsh-0.17-71.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5708/rsh-0.17-71.fc19
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2013-04-30 04:34:13 UTC
rsh-0.17-71.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Francis.Montagnac 2013-04-30 07:17:36 UTC
rsh fails between two machines having only IPV4 adresses if one uses
the new rsh.socket systemd file to activate it.

The error message ares: (IPs and names made anonymous):

  rshd[2294]: Host addr ::ffff:X.Y.Z.T not listed for host A.B.C
  rshd[2294]: rsh denied to root.C as root: Host address mismatch for %s  

It works if:

  - one starts this service the old way with xinetd

  - or if one change rsh.socket to use IPV4, ie:

    ListenStream=a.b.c.d:514

    where a.b.c.d is the IP number of the machine

Comment 15 Michal Sekletar 2013-04-30 16:07:18 UTC
I was trying to reproduce the issue. I used two clean Fedora installations with out of box settings, except IPv6, which I disabled entirely on both hosts. I tried rsh and rlogin and it worked as expected.

Can you describe your environment and settings in greater detail?

Comment 16 Francis.Montagnac 2013-05-01 07:05:24 UTC
> Can you describe your environment and settings in greater detail?

Our network uses a DHCP and DNS IPv4 only servers. The fedora machines
have IPv6 enabled and obtain their IPs through DHCP.

You can reproduce this problem on a single machine as follows:

  - configure it to use IPv6 (the default)

    Then rsh.socket will listen on IPv6 only (see below), while
    allowing IPv4 connections (with IPv4-on-IPv6 if I understand
    correctly)

  - add localhost4 to /root/.rhosts

One obtains:

    rsh localhost4 hostname
    Host address mismatch for localhost

/var/log/messages 

    May  1 08:40:57 local36 systemd[1]: Starting Remote Shell Facilities Server...
    May  1 08:40:57 local36 systemd[1]: Started Remote Shell Facilities Server.
    May  1 08:40:57 local36 rshd[26702]: Host addr ::ffff:127.0.0.1 not listed for host localhost
    May  1 08:40:57 local36 rshd[26702]: rsh denied to root@localhost as root: Host address mismatch for %s
    May  1 08:40:57 local36 rshd[26702]: rsh command was 'hostname'

rsh.socket listen on IPv6 only, unlike ssh that listen on IPv4 and
IPv6:

    lsof -i tcp:514,22
    COMMAND  PID USER   FD   TYPE DEVICE SIZE/OFF NODE NAME
    systemd    1 root   56u  IPv6  41015      0t0  TCP *:shell (LISTEN)
    sshd     777 root    3u  IPv4  16626      0t0  TCP *:ssh (LISTEN)
    sshd     777 root    4u  IPv6  16628      0t0  TCP *:ssh (LISTEN)

Comment 17 Francis.Montagnac 2013-05-02 08:09:30 UTC
Looking at the sources, I think that it should suffice to modify the
following:

rshd/rshd.c:
  in the findhostname function, replace the call of inet_ntop that
  initialize remote_address by:
  
  getnameinfo (fromp, fromlen, remote_address, INET6_ADDRSTRLEN,
               NULL, 0, NI_NUMERICHOST)

rlogind/network.c:
  rewrite the soaddr_eq_ip function to handle v4-mapped-on-v6
  addresses

I may try to do that myself. Let me know.

Comment 18 Francis.Montagnac 2013-07-01 15:27:31 UTC
I saw that you updated recently the RPM to the version 0.17-72

  - fix handling of non-native IPv6 connections via AF_INET6 socket

I tested it, and it works.

Thanks a lot.