| Summary: | Review Request: rubygem-mg - Minimal gem | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Darryl L. Pierce <dpierce> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, package-review, tross |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-mg-0.0.8-2.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-24 12:38:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Darryl L. Pierce
2011-09-12 14:26:48 UTC
I'm taking this one. - Remove unused definitions (ruby_sitelib, ruby_sitearch)
- You don't need to specify the BuildRoot, see [1]
- Be a little more verbose in the description section (you can for example add the line from README.mkd - "Minimalist way to build and publish gems using Rake. Also build tarballs.").
- Consider introducing doc subpackage and moving %doc %{gemdir}/doc/%{gemname}-%{version} into it.
- Next time, consider using gem2rpm, it saves a lot of work when packaging rubygems.
[1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
(In reply to comment #2) > - Remove unused definitions (ruby_sitelib, ruby_sitearch) Done. > - You don't need to specify the BuildRoot, see [1] Done. > - Be a little more verbose in the description section (you can for example add > the line from README.mkd - "Minimalist way to build and publish gems using > Rake. Also build tarballs."). Done > - Consider introducing doc subpackage and moving %doc > %{gemdir}/doc/%{gemname}-%{version} into it. Thanks for the suggestion. I've put that separation back into the spec. > - Next time, consider using gem2rpm, it saves a lot of work when packaging > rubygems. This spec file -was- generated with gem2rpm. > [1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Here are the updated files: SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-mg.spec SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-mg-0.0.8-1.fc15.src.rpm Some additional comments:
- You should bump the release number, when doing changes, and add the concrete steps into changelog (use rpmdev-bumspec).
- %doc %{geminstdir}/README.mkd should stay in the main package, as it contains the licensing information.
- Summary shouldn't end with period, see [1].
[1] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Spec_file_pieces_explained
(In reply to comment #4) > Some additional comments: > - You should bump the release number, when doing changes, and add the concrete > steps into changelog (use rpmdev-bumspec). > - %doc %{geminstdir}/README.mkd should stay in the main package, as it contains > the licensing information. Done. > - Summary shouldn't end with period, see [1]. Done. Here are the updated files: SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-mg.spec SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-mg-0.0.8-2.fc15.src.rpm Looks ok now, this package is APPROVED. Thank you! New Package SCM Request ======================= Package Name: rubygem-mg Short Description: Minimalist way to build and publish gems using Rake. Also build tarballs Owners: mcpierce Branches: f15 f16 InitialCC: mcpierce Git done (by process-git-requests). rubygem-mg-0.0.8-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/rubygem-mg-0.0.8-2.fc15 rubygem-mg-0.0.8-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-mg-0.0.8-2.fc16 rubygem-mg-0.0.8-2.fc15 has been pushed to the Fedora 15 testing repository. rubygem-mg-0.0.8-2.fc16 has been pushed to the Fedora 16 stable repository. rubygem-mg-0.0.8-2.fc15 has been pushed to the Fedora 15 stable repository. |