Bug 7377

Summary: rp3-config crashes
Product: [Retired] Red Hat Linux Reporter: Paolo Nason <paolo.nason>
Component: rp3Assignee: Jonathan Blandford <jrb>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: ddumas
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 1999-12-01 15:11:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Paolo Nason 1999-11-27 20:05:54 UTC
in rp3-1.0.1 I had a segmentation fault problem when using rp3-config.
In account.cc, the function load_accounts, the line marked 3
should go in 1; otherwise, if the continue statement 2 is reached,
tmp does not get updated, and the same interfaced is released twice,
causing segmentation faults when freeing the buffers twice.
The bug has gone away with the modification I propose.

A different problem arises in inteface.c, at the line
glob("/etc/sysconfig/network-scripts/ifcfg-*", 0, NULL, &globbuf);
a file ifcfg- was present in my configuration, causing problems.
Paolo Nason

load_accounts     (void)
  tmp = ifs;
  while (tmp != NULL)
      interface* iface = (interface*)tmp->data;
1      /* should be here */
      tmp = g_list_next(tmp);
      if (strncmp(iface->logicalName, "ppp", strlen("ppp")) == 0)
          Account* a;
          char* tmp;

          tmp = svGetValue (iface->ifcfg, "WVDIALSECT");
          if (tmp == NULL)
              interface_free (iface);
2              continue;

3      tmp = g_list_next(tmp);
  return accounts;

Comment 1 Michael K. Johnson 1999-11-30 15:58:59 UTC
Please try the test release
and report whether it fixes this problem for you.

Comment 2 Michael K. Johnson 1999-12-01 15:01:59 UTC
Paolo reports this not fixed in 1.0.2.

Comment 3 Jonathan Blandford 1999-12-01 15:11:59 UTC
Thanks for the patch.  This is fixed in the source and will be in the next