Bug 738509

Summary: xulrunner forces soft-float ABI for all arm targets
Product: [Fedora] Fedora Reporter: Brendan Conoboy <blc>
Component: xulrunnerAssignee: Gecko Maintainer <gecko-bugs-nobody>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 15CC: caillon, gecko-bugs-nobody, johnp, mcepl, pbrobinson, stransky, walters
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: other   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-23 14:28:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 245418    
Description Flags
This patch allows xulrunner to build on armv7hl systems
Patch to properly configure the various arm platforms none

Description Brendan Conoboy 2011-09-15 02:54:03 UTC
Description of problem:

The xulrunner package includes special handling for ARM systems that modify the flags passed to gcc and g++.  One of the flags set the floating point ABI to soft-float, even if the system is hard float.  When the hard float and soft float options are mixed together, gcc bails resulting in a FTBFS.

Version-Release number of selected component (if applicable):

Observed in the latest F15 update to xulrunner, xulrunner-6.0.2-1.fc15.

How reproducible:

Every time.  The symptom is when autoconf tries to identify the size of int * and gets a result of '0'.

Steps to Reproduce:
1. Install Fedora-ARM F15 rootfs
2. Try to build xulrunner.
3. Watch configure break.
Actual results:

Configure breaks.

Expected results:

Package should build.

Additional info:

The attached patch removes the setting of the float ABI, instead letting autoconf do its job and get the right flags from gcc (EG, --mfloat-abi=hardfp).  This patch is against xulrunner-6.0.2-1.fc15.  I'm not clear on Fedora package standards wrt configure regeneration, so this patch does include changes to the generated configure.  Taking just the changes to the two configure.in's and rerunning autoconf should give the same results.

Comment 1 Brendan Conoboy 2011-09-15 02:55:52 UTC
Created attachment 523294 [details]
This patch allows xulrunner to build on armv7hl systems

This patch allows xulrunner to build on armv7hl systems.  It specifically stops configure from always specifying soft-float ABI and instead lets configure work out the right setting itself.

Comment 3 Niels de Vos 2011-12-22 09:44:14 UTC
I think this is filed upstream already (currently still open):
- https://bugzilla.mozilla.org/show_bug.cgi?id=632915

Comment 4 Peter Robinson 2011-12-22 10:44:49 UTC
Created attachment 549168 [details]
Patch to properly configure the various arm platforms

Based on xulrunner 9.0 there's proper configure options to set the various build options for the various ARM build options so we just need to set them so they get built. This patch to the current latest xulrunner.spec sets the options we want.

Comment 5 Peter Robinson 2011-12-23 14:28:51 UTC
Pushed spec changes to xulrunnr in rawhdide.