Bug 739334
| Summary: | Adjust service disabling for systemd, and remove some dead wood | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> | ||||||
| Component: | spin-kickstarts | Assignee: | Bruno Wolff III <bruno> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 16 | CC: | bruno, kevin, maxamillion, vanmeeuwen+fedora | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | RejectedNTH | ||||||||
| Fixed In Version: | spin-kickstarts-0.16.4-1.fc16 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-10-29 06:32:06 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Adam Williamson
2011-09-17 20:05:33 UTC
proposing as final NTH. Created attachment 523724 [details]
the patch!
Created attachment 523779 [details]
updated patch: adds --no-reload
this patch uses --no-reload for the disabling, which is more correct. not having it doesn't cause trouble while livesys is still a sysv service, it seems, but it's best to have it anyway.
Discussed at 2011-09-30 NTH review meeting. Rejected as NTH, it doesn't make sense to touch sensitive live spin bits during a freeze; we should fix this before freeze if we're going to fix it. I'll try to get this tested this weekend. If things look OK after some simple testing, I'll commit it so we can get it really tested before final freeze. I didn't get as far as I would have liked, so I am not ready to push this out just yet. I did get a live image built using this patch with updates-testing. It booted up, but seems to have had a problem with selinux. I had to change to permissive mode to get gdm to work. I didn't get a chance to check the services yet, though I can say that firstboot didn't start. it does sound like that's not related to the patch, but obviously complicates testing. you could try without updates-testing, i guess. spin-kickstarts-0.16.2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spin-kickstarts-0.16.2-1.fc16 I finally got around to looking at whether what the patch changes looks good and it did. The other issue had already been fixed. So I pushed the change to the repo. Also it is a good time to rebuild the spin-kickstarts package to get an up to date version in before final freeze. Package spin-kickstarts-0.16.2-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing spin-kickstarts-0.16.2-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-14428 then log in and leave karma (feedback). spin-kickstarts-0.16.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spin-kickstarts-0.16.3-1.fc16 spin-kickstarts-0.16.4-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spin-kickstarts-0.16.4-1.fc16 spin-kickstarts-0.16.4-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |