Bug 739417
Summary: | Review Request: php53-php-gettext - Gettext emulation in PHP | ||
---|---|---|---|
Product: | [Fedora] Fedora EPEL | Reporter: | Robert Scheck <redhat-bugzilla> |
Component: | Package Review | Assignee: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | el5 | CC: | fedora-package-review, sanjay.ankur |
Target Milestone: | --- | Flags: | sanjay.ankur:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | php53-php-gettext-1.0.11-3.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-11-13 01:32:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 727000 |
Description
Robert Scheck
2011-09-18 22:35:48 UTC
Review: + OK - NA ? Issue + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. - Sources match upstream md5sum: - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. [ankur@ankur SRPMS]$ rpmlint php53-php-gettext-1.0.11-3.src.rpm ../SPECS/php53-php-gettext.spec ../RPMS/noarch/php53-php-gettext-1.0.11-3.fc16.noarch.rpm php53-php-gettext.noarch: E: incorrect-fsf-address /usr/share/doc/php53-php-gettext-1.0.11/COPYING php53-php-gettext.noarch: E: incorrect-fsf-address /usr/share/php/gettext/streams.php php53-php-gettext.noarch: E: incorrect-fsf-address /usr/share/php/gettext/gettext.php php53-php-gettext.noarch: E: incorrect-fsf-address /usr/share/php/gettext/gettext.inc 2 packages and 1 specfiles checked; 4 errors, 0 warnings. Please ask upstream to update the address. Not a blocker. + final provides and requires are sane: [ankur@ankur temp]$ review-req-check == php53-php-gettext-1.0.11-3.fc16.noarch.rpm == Provides: php-php-gettext = 1.0.11-3.fc16 php53-php-gettext = 1.0.11-3.fc16 Requires: php53-common php53-mbstring SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version + check for outstanding bugs on package. (For core merge reviews) Issues: None XXX APPROVED XXX Thank you very much for the package review. New Package SCM Request ======================= Package Name: php53-php-gettext Short Description: Gettext emulation in PHP Owners: robert Branches: el5 InitialCC: Git done (by process-git-requests). php53-php-gettext-1.0.11-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php53-php-gettext-1.0.11-3.el5 php53-php-gettext-1.0.11-3.el5 has been pushed to the Fedora EPEL 5 testing repository. php53-php-gettext-1.0.11-3.el5 has been pushed to the Fedora EPEL 5 stable repository. |