Bug 740256

Is this still happening on Fedora 16 with the latest wicd update?

as far I can say, it's corrected in Fedora 16 with wicd-gtk-1.7.0-9.fc16.noarch

I confirm the correction of this bug with  wicd-gtk-1.7.0-10.fc16.noarch ... But ...


The same kind of problem is now "one call before" in the function "add_profile" 
 file "/usr/share/wicd/gtk/netentry.py" 
 code extract:
722     def add_profile(self, widget):
 723         """ Add a profile to the profile list. """
 724         response = string_input("Enter a profile name", "The profile name " +
 725                                   "will not be used by the computer. It " +
 726                                   "allows you to " +
 727                                   "easily distinguish between different network " +
 728                                   "profiles.", "Profile name:").strip()
 729 
 730         # if response is "" or None
 731         if not response:
 732             error(None, "Invalid profile name", block=True)
 733             return False

an exception "NoneType has no method strip" will occur at line "728" each time a user press the "Cancel Buttom" or enter 'None python string'.
The guilty is of course, ... :input_string() because it's complete name is
"input_string_but_returns_TheString_or_None" ... Hereafter, the patch I made
in  /usr/share/wicd/gtk/guiutil.py

109 # ath 20120220 : always return a string : '' by default <=> No Entry or OK_Cancel press */
110     text = ''
111     if dialog.run() == gtk.RESPONSE_OK:
112 # ath 20120220 and ... strip it
113         text = entry.get_text().strip()
114 # ath  20120220        dialog.destroy()
115 # ath  20120220        return text
116 # ath  20120220    else:
117     dialog.destroy()
118     return text
119 

in place of:
109     if dialog.run() == gtk.RESPONSE_OK:
110         text = entry.get_text()
111         dialog.destroy()
112         return text
113     else:
114         dialog.destroy()
115         return None

with this patch, you have also to remove the now redundant strip() in add_profile(), after the string_input() call because it is useless.

P.S  Sorry, for my verbosity, but in french I am very more concise
 and as we say in french: Ouf !!! (<=>  mon laius est enfin terminé)

A short review of "my wicd reported problems" the proposed patch in comments 3
would resolve   "https://bugzilla.redhat.com/show_bug.cgi?id=740309" i.e 740309
the "740317 Description field" last lines are: .
from bug https://bugzilla.redhat.com/show_bug.cgi?id=740309
:Traceback (most recent call last):
:  File "/usr/share/wicd/gtk/netentry.py", line 728, in add_profile
:    "profiles.", "Profile name:").strip()
:AttributeError: 'NoneType' object has no attribute 'strip'

in summary at now :
   this bug is closed
   740309: not closed but can be closed with "patch comments 3 of this"
   740309: "Comment #2" opens a new bug, not corrected by the patch. The new one
   isn't directly or indirectly bound to the first. It's just the same syndrom

Can you please attach your proposed patches as unified diffs (diff -u)?  I want to make sure I am getting everything you are proposing and it is difficult to follow in Bugzilla comments.

ok for this 2 files are modified.
1) guiutil.py
[Alain@alix wicd]$ diff -u  packages/wicd-1.7.0-10/usr/share/wicd/gtk/guiutil.py patches/guiutil-740256-corrected.py 
--- packages/wicd-1.7.0-10/usr/share/wicd/gtk/guiutil.py        2010-01-15 05:49:11.000000000 +0100
+++ patches/guiutil-740256-corrected.py 2012-03-27 09:11:53.171323999 +0200
@@ -106,13 +106,11 @@
     dialog.vbox.pack_end(hbox, True, True, 0)
     dialog.show_all()
 
+    text = ''
     if dialog.run() == gtk.RESPONSE_OK:
-        text = entry.get_text()
-        dialog.destroy()
-        return text
-    else:
-        dialog.destroy()
-        return None
+        text = entry.get_text().strip()
+    dialog.destroy()
+    return text
 
 class SmallLabel(gtk.Label):
     def __init__(self, text=''):

2) netentry.py 
[Alain@alix wicd]$ diff -u packages/wicd-1.7.0-10/usr/share/wicd/gtk/netentry.py patches/netentry-740256-corrected.py
--- packages/wicd-1.7.0-10/usr/share/wicd/gtk/netentry.py       2010-01-15 05:49:11.000000000 +0100
+++ patches/netentry-740256-corrected.py        2012-03-27 09:19:13.533953730 +0200
@@ -725,7 +725,7 @@
                                   "will not be used by the computer. It " +
                                   "allows you to " + 
                                   "easily distinguish between different network " +
-                                  "profiles.", "Profile name:").strip()
+                                  "profiles.", "Profile name:")

I meant as actual file attachments to this bug in text/plain format, but these changes are small enough I can read it from the bugzilla comment.

wicd-1.7.0-13.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/wicd-1.7.0-13.fc15

Package wicd-1.7.0-13.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing wicd-1.7.0-13.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-6779/wicd-1.7.0-13.fc15
then log in and leave karma (feedback).

wicd-1.7.0-13.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.