Bug 740562
| Summary: | Review Request: telepathy-kde-presence-applet - Plasma applet for managing your Telepathy account presence | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | Package Review | Assignee: | Radek Novacek <rnovacek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, ovasik, package-review, rnovacek |
| Target Milestone: | --- | Flags: | rnovacek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-09-26 14:37:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 723123, 740561 | ||
| Bug Blocks: | 656997 | ||
|
Description
Rex Dieter
2011-09-22 13:20:39 UTC
Name: ok License: ok Source: wrong, should be http://download.kde.org/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2 instead of http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2 BRs/Reqs: ok Macros used consistently: ok ldconfig: NA Desktop file validations: NA Locales: NA Docs: ok Devel: NA Files: ok Build: ok rpmlint: please fix ./telepathy-kde-presence-applet.spec:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 4) Spec URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-presence-applet-0.1.0-2.fc15.src.rpm %changelog * Fri Sep 23 2011 Rex Dieter <rdieter> 0.1.0-2 - fix Source0 URL - fix spaces/tabs *** Bug 730328 has been marked as a duplicate of this bug. *** Thanks for fixing the issues, setting fedora-review+. New Package SCM Request ======================= Package Name: telepathy-kde-presence-applet Short Description: Plasma applet for managing your Telepathy account presence Owners: jreznik rdieter Branches: f15 f16 Git done (by process-git-requests). imported This requires a script engine which isn't in Fedora yet: plasma4(scriptengine-declarativeapplet) as found by my automatic dependency extractor. The whole applet is written in QML, it won't work at all without a script engine for QML. What 4.7 has lists these properties instead: X-EngineName=declarativeappletscript X-Plasma-API=declarativeappletscript X-KDE-PluginInfo-Name=qmlscript Now I do think the depextractor does the wrong thing there (it prefers the X-KDE-PluginInfo-Name, but it should be using the X-Plasma-API here; that said, I think it's also broken for those properties to say different things), but still, neither of those match "declarativeapplet" which this is asking for. So it turns out that I got confused because the dependency was incorrectly hand-typed into IRC. The dependency as listed by http://koji.fedoraproject.org/koji/rpminfo?rpmID=2716469 is on plasma4(scriptengine-declarativeappletscript), which is correct. The problem is that the autoprov script gets confused because the .desktop file for the script engine has a name != the API for some stupid reason. I need to fix the autoprov script to ignore the name and only pick the API for script engines. This chain build should fix the autoprov: http://koji.fedoraproject.org/koji/taskinfo?taskID=3380164 FYI, this is the relevant kde-settings commit: https://fedorahosted.org/kde-settings/changeset/294 |