Bug 741633

Summary: koji-web does not handle 64-bit inodes
Product: [Fedora] Fedora Reporter: Michael Cronenworth <mike>
Component: kojiAssignee: Mike McLean <mikem>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: dcantrell, mikem
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-16 21:32:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
trial fix none

Description Michael Cronenworth 2011-09-27 13:25:09 UTC
Description of problem:
An error has occurred while processing your request.
Fault: <Fault 1: "<type 'exceptions.OverflowError'>: int exceeds XML-RPC limits">

Traceback (most recent call last):
  File "/usr/share/koji-web/lib/kojiweb/publisher.py", line 16, in publish_object
    return old_publish_object(req, object)
  File "/usr/lib64/python2.7/site-packages/mod_python/publisher.py", line 425, in publish_object
    return publish_object(req,util.apply_fs_data(object, req.form, req=req))
  File "/usr/lib64/python2.7/site-packages/mod_python/util.py", line 554, in apply_fs_data
    return object(**args)
  File "/usr/share/koji-web/scripts/index.py", line 668, in getfile
    output = server.listTaskOutput(taskID, stat=True)
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1510, in __call__
    return self.__func(self.__name,args,opts)
  File "/usr/lib/python2.7/site-packages/koji/__init__.py", line 1760, in _callMethod
    raise err
Fault: <Fault 1: "<type 'exceptions.OverflowError'>: int exceeds XML-RPC limits">


Version-Release number of selected component (if applicable):
koji-1.6.0-1.fc14.noarch
mock-1.1.15-1.fc14.noarch


How reproducible:
Every time I try to build any new package or calling "regen-repo".


Steps to Reproduce:
1. Queue up a new package to build.
2. Navigate to the task web page.
3. Click on root.log, build.log, or any .log file.
  
Actual results:
The Python traceback is shown on the web page.


Expected results:
The log file.


Additional info:
I can view logs made prior to a large Fedora update I ran several days ago. It's only builds made since the update that I cannot view the logs of. I have updated to the last mock, but it did not change anything. I also downgraded back to mock 1.1.10 that I had prior to the update, but it also did not change anything.

Comment 1 Michael Cronenworth 2011-09-27 23:16:50 UTC
I believe this has something to do with 64-bit inodes. After disabling them, new package build log files can be viewed through koji-web. I'm not sure if koji or Python is not ready for 64-bit inodes, but I'm leaning toward koji. yum seems to handle operations just fine.

Comment 2 Mike McLean 2011-09-28 04:48:50 UTC
probably, xmlrpclib enforces the int limitations of the xmlrpc standard, which is the origin of the error. we've worked around it a few places by returning larger int as strings (which is a bit silly since everything in xmlprc is a string representation anyway).

Comment 3 Mike McLean 2011-10-12 20:41:19 UTC
I've got a fix for this. Should be able to push it out soon. I'll attach a patch for the impatient.

Comment 4 Mike McLean 2011-10-12 20:42:16 UTC
Created attachment 527784 [details]
trial fix

Comment 5 Michael Cronenworth 2011-10-12 21:04:24 UTC
Thanks, Mike.

The remaining problem is that 32-bit mock directories failed to build packages. Some 32-bit packages could not read/write directories or files with 64-bit inodes. This is one hurdle out of the way though.

Comment 6 Mike McLean 2011-10-14 19:02:49 UTC
For mock, you'll want to file a separate bug and/or start a separate discussion on the buildsys list.

Comment 7 Fedora End Of Life 2012-08-16 21:32:08 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping