Bug 742240

Summary:	rpm upgrade replaces pulp.conf
Product:	[Retired] Pulp	Reporter:	Justin Sherrill <jsherril>
Component:	z_other	Assignee:	James Slagle <jslagle>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.0.0	Keywords:	Triaged
Target Milestone:	---
Target Release:	Sprint 29
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-24 20:15:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Justin Sherrill 2011-09-29 13:37:57 UTC

Description of problem:


Version-Release number of selected component (if applicable):
pulp-0.0.235-1.fc15.noarch

How reproducible:
always

Steps to Reproduce:
1. Install a version of pulp
2. Make a customization to pulp.conf
3. Upgrade pulp
  
Actual results:
customized pulp.conf is moved to pulp.conf.rpmsave, and new pulp.conf is laid down.


Expected results:

custom pulp.conf stays in place.


I understand that as features are added, config values need to be added to pulp.conf, but we need   to upgrade pulp without having to worry about combining the old and new pulp.conf together by hand.

In satellite we had a default set of config values and one for user customization (So we could add new default values but the user could keep their custom values set).  Something like this would good.

Comment 1 James Slagle 2011-10-27 20:53:50 UTC

We need to use %config(noreplace) in our spec file so that the existing config file (if it has changes) will not be overwritten.

Our config loading system already has a method in place to make use of default values.

Comment 2 James Slagle 2011-10-27 21:13:42 UTC

committed to pulp master: 810b193c9a5156055ccb5e05fe91beb07ecd2b09

Comment 3 Jeff Ortel 2011-10-28 23:12:44 UTC

build: 0.244

Comment 4 Preethi Thomas 2011-10-31 13:41:46 UTC

verified

[root@preethi ~]# rpm -q pulp
pulp-0.0.244-1.fc15.noarch

[root@preethi ~]# ls -l /etc/pulp/
total 36
drwxrwxr-x. 2 apache apache 4096 Oct 31 09:42 admin
-rwxrwxr-x. 1 apache apache  599 Oct 28 18:50 cds.conf
-rwxrwxr-x. 1 apache apache 1487 Aug  1 08:52 client.conf.rpmsave
drwxrwxr-x. 2 apache apache 4096 Oct 31 09:42 consumer
drwxrwxr-x. 2 apache apache 4096 Oct 31 09:42 logging
-rwxrwxr-x. 1 apache apache 3888 Oct 28 08:42 pulp.conf
-rwxrwxr-x. 1 apache apache 3888 Oct 24 07:42 pulp.conf.rpmsave
-rwxrwxr-x. 1 apache apache  206 Oct 28 18:50 repo_auth.conf
-rwxrwxr-x. 1 apache apache  205 Sep 23 11:47 repo_auth.conf.rpmsave
[root@preethi ~]#

Comment 5 Preethi Thomas 2012-02-24 20:15:41 UTC

Pulp v1.0 is released
Closed Current Release.

Comment 6 Preethi Thomas 2012-02-24 20:17:18 UTC

Pulp v1.0 is released.