Bug 742276

Summary: /etc/init.d/network does not like names produced by NetworkManager
Product: [Fedora] Fedora Reporter: Paolo Bonzini <pbonzini>
Component: initscriptsAssignee: Bill Nottingham <notting>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dcbw, iarlyy, jonathan, notting, plautrba, rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: initscripts-9.33-1.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-17 00:46:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 742273    
Bug Blocks:    
Attachments:
Description Flags
potential patch none

Description Paolo Bonzini 2011-09-29 15:01:55 UTC
NetworkManager only escapes space, slash and backslash.

The network init script, instead, matches ifcfg files against ifcfg-[A-Za-z0-9#\._-]\+.  This causes a lot of confusion when network files contain other characters (typically for weird wireless SSIDs).

Actually, NetworkManager will also produce files with a space, but that's arguably a bug in NM rather than in the initscripts.  Still, I'm marking the space-in-filename bug as blocking this one.

Version-Release number of selected component (if applicable):
9.32

Comment 1 Paolo Bonzini 2011-09-29 15:02:47 UTC
Should have been "NetworkManager only escapes space, slash and backslash when transforming a network name into a file for /etc/sysconfig/network-scripts".

Comment 2 Bill Nottingham 2011-09-29 18:03:16 UTC
What happens if you just drop that match entirely?

Comment 3 Bill Nottingham 2011-09-29 18:04:17 UTC
Created attachment 525611 [details]
potential patch

Comment 4 Paolo Bonzini 2011-09-30 10:54:16 UTC
Looks good!

Comment 6 Fedora Update System 2011-10-12 21:12:36 UTC
initscripts-9.33-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/initscripts-9.33-1.fc16

Comment 7 Fedora Update System 2011-10-13 18:12:29 UTC
Package initscripts-9.33-1.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing initscripts-9.33-1.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-14259
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2011-10-17 00:46:01 UTC
initscripts-9.33-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.