Bug 742453
| Summary: | Review Request: Matahari - QMF Agents for Linux guests | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Radek Novacek <rnovacek> |
| Component: | Package Review | Assignee: | Lon Hohberger <lhh> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.8 | CC: | jreznik, matahari-maint, notting, ovasik, pm-rhel |
| Target Milestone: | rc | ||
| Target Release: | 5.8 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-07 19:07:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 188273, 665092 | ||
|
Description
Radek Novacek
2011-09-30 08:08:03 UTC
Review Request for matahari on Fedora (outdated version of matahari): https://bugzilla.redhat.com/show_bug.cgi?id=511148 Review Request for mingw32-matahari on Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=674152 Add matahari to RHEL-6 bug: https://bugzilla.redhat.com/show_bug.cgi?id=658828 Add mingw32-matahari to RHEL-6 bug: https://bugzilla.redhat.com/show_bug.cgi?id=658840 rpmlint is okay:
[root@snap ~]# rpmlint matahari-0.4.4-7.el5.src.rpm
matahari.src: I: enchant-dictionary-not-found en_US
matahari.src:569: W: macro-in-%changelog %{_datadir}
matahari.src:78: W: mixed-use-of-spaces-and-tabs (spaces: line 78, tab: line 18)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
The warning on line 569 is bogus.
What I don't really like is the comment in the changelog:
- Link libresolv statically
Why is this done?
Russell pointed me at this, I think we should mention it in the spec file: https://bugzilla.redhat.com/show_bug.cgi?id=723928 As in "Statically link because of rhbz#723928" or something. Lon, thanks for noticing, I added the bugzilla reference to patch comment but forget to add it to changelog. Fixed now: Spec URL: http://rnovacek.fedorapeople.org/matahari.spec SRPM URL: http://rnovacek.fedorapeople.org/matahari-0.4.4-7.el5.src.rpm Ok, thanks Radek! |