Bug 742484

Summary: should be also have snapshot on floppy
Product: Red Hat Enterprise Linux 6 Reporter: juzhang <juzhang>
Component: qemu-kvmAssignee: Markus Armbruster <armbru>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2CC: acathrow, chayang, michen, mkenneth, tburke, virt-maint
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-0.12.1.2-2.206.el6 Doc Type: Bug Fix
Doc Text:
Cause: Snapshotting ignored drives with removable media Consequence: Reverting to a snapshot didn't revert writes to floppies Fix: Ignore drives with removable media only when read-only or empty Result: Snapshotting now treats writable floppies like any other writable drive
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 16:04:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 742458, 748554    

Description juzhang 2011-09-30 10:01:59 UTC
Description of problem:
For now,no snapshot on floppy


Version-Release number of selected component (if applicable):
qemu-kvm-0.12.1.2-2.193.el6.x86_64
guest kernel
#uname -r
2.6.32-195.el6.x86_64


How reproducible:
100%

Steps to Reproduce:
1.boot guest
/usr/libexec/qemu-kvm  -no-kvm-pit-reinjection -rtc-td-hack -m 1G -smp 1 -M rhel6.2.0 -drive file=/root/zhang/armbu/mainqcow2.qcow2,if=none,id=drive-virtio0-0-0,format=qcow2,werror=stop,rerror=stop,cache=none,aio=native -device virtio-blk-pci,drive=drive-virtio0-0-0,id=virti0-0-0,bootindex=1 -netdev tap,id=hostnet0,vhost=on,script=/etc/qemu-ifup -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:56:00:94:a3:21 -uuid 9e6f04cf-2ad7-45aa-9333-2d2ee26570c6 -balloon none -monitor stdio -vnc :10 -drive file=/root/zhang/armbu/qemuiso.qcow2,if=none,media=cdrom,id=drive-ide0-1-0,readonly=on,format=raw -device ide-drive,bus=ide.1,unit=0,drive=drive-ide0-1-0 -fda /root/zhang/armbu/qemufloppy.qcow2
2.(qemu) savevm
3.quit
4../bb.sh
cat bb.sh 
for i in mainqcow2.qcow2 qemuiso.qcow2 qemufloppy.qcow2; 
 do 
    echo $i;
    qemu-img snapshot -l $i; 
 done
  
Actual results:
mainqcow2.qcow2
Snapshot list:
ID        TAG                 VM SIZE                DATE       VM CLOCK
1         1                      3.0M 2011-09-29 04:37:57   00:00:06.353
qemuiso.qcow2
qemufloppy.qcow2

Expected results:
should be also have  snapshot on floppy

Additional info:

Comment 1 juzhang 2011-09-30 10:02:26 UTC
http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-September/msg00677.html

According to our test results. 
with this patch fix this issue.add this issue into tracker bug(bz742458)

Comment 7 juzhang 2011-10-20 06:28:46 UTC
Verified this issue with qemu-kvm-0.12.1.2-2.199.el6,the steps are as same as comment0.

After step4

Results
# ./bb.sh 
mainqcow2.qcow2
Snapshot list:
ID        TAG                 VM SIZE                DATE       VM CLOCK
1                                2.8M 2011-10-20 09:35:48   00:00:04.197
qemuiso.qcow2
qemufloppy.qcow2
Snapshot list:
ID        TAG                 VM SIZE                DATE       VM CLOCK
1                                   0 2011-10-20 09:35:48   00:00:04.197

Comment 8 juzhang 2011-10-28 05:32:41 UTC
We also did virtual block and usb device functional testing,did not find block
or regression bugs.
https://tcms.engineering.redhat.com/run/29499/
https://tcms.engineering.redhat.com/run/29338/

Comment 11 Eduardo Habkost 2011-10-28 18:00:41 UTC
Moving to ON_QA because Errata Tool did not do it

Comment 13 Markus Armbruster 2011-11-18 09:48:49 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: Snapshotting ignored drives with removable media
Consequence: Reverting to a snapshot didn't revert writes to floppies
Fix: Ignore drives with removable media only when read-only or empty
Result: Snapshotting now treats writable floppies like any other writable drive

Comment 14 errata-xmlrpc 2011-12-06 16:04:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html