Bug 742626

Summary: Review Request: qpid-qmf
Product: Red Hat Enterprise Linux 5 Reporter: Perry Myers <pmyers>
Component: Package ReviewAssignee: Radek Novacek <rnovacek>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: high    
Version: 5.8CC: jreznik, jross, matahari-maint, notting, ovasik, pm-rhel, rrakus
Target Milestone: rc   
Target Release: 5.8   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-07 19:20:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 188273, 733358    

Description Perry Myers 2011-09-30 19:47:33 UTC
Description of problem:
PackageReview bugzilla for adding qpid-qmf to RHEL 5

Comment 2 Justin Ross 2011-10-06 18:21:04 UTC
Just confirming: those are the correct files to work from.

Comment 3 Jaroslav Reznik 2011-10-07 08:53:20 UTC
SPEC URL: http://scratch.englab.brq.redhat.com/jreznik/redhat/matahari/qpid-qmf.spec
SRPM URL: http://scratch.englab.brq.redhat.com/jreznik/redhat/matahari/qpid-qmf-0.12-6.el5.src.rpm

Description: An extensible management framework layered on Qpid messaging

Note: this is SRPM from el6 (0.12-6) already prepared for use in el5, as the intention is to go with el6 version

Comment 4 Radek Novacek 2011-10-07 10:29:42 UTC
Name: ok
License: ok
Source: NOT ok, Source0 should point to upstream release tarball or should be commented how to obtain it
BRs/Reqs: ok
Macros used consistently: NOT ok, Vendor tag shouldn't be present
ldconfig: ok
Desktop file validations: NA
Locales: NA
Docs: doc is missing, at least LICENSE and README.txt should be present
Devel: ok
Files: ok
Build: package builds locally
rpmlint:
qpid-qmf.src:181: W: macro-in-comment %exclude
qpid-qmf.src:181: W: macro-in-comment %{python_sitelib}
qpid-qmf.src:213: W: macro-in-comment %{rhel_4}
qpid-qmf.src:226: W: macro-in-comment %patch1
qpid-qmf.src: W: patch-not-applied Patch1: mutable.patch
qpid-qmf.src: W: invalid-url Source0: qpid-qmf-0.12.tar.gz
qpid-qmf.x86_64: W: no-documentation

Comment 6 Radek Novacek 2011-10-07 13:23:44 UTC
Seems good. Moving to RHEL5.0-ACCEPT