| Summary: | [webadmin] Bookmarks implementation | ||
|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Asaf Shakarchi <asaf> |
| Component: | ovirt-engine-webadmin | Assignee: | Vojtech Szocs <vszocs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | unspecified | CC: | ecohen, iheim |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-09 08:06:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Asaf Shakarchi
2011-10-02 17:12:16 UTC
> List bookmarks on the left side panel
Done and pushed, git commit hash 15451477719241e72fe10e1fafb7cb93e63938c2
> Bookmarks dialog based view for adding new bookmarks
Done, New/Edit bookmark dialog, sending patch
New/Edit bookmark dialog pushed, git commit hash 9e59fd7e8f795c29ca28b18c0b89e749483a282e Extending the scope of this BZ to the Bookmark action toolbar on the left pane as well. Bookmark toolbar finished, action buttons bound to corresponding BookmarkListModel commands.
There is still one issue with bookmarks:
Assume user saves bookmark for search string "Host: name = dev-01". When user clicks this bookmark, following happens:
1) CommonModel.BookmarkListModel_Navigated() sets the search string according to bookmark value ("Host: name = dev-01"), search panel UI is updated
2) CommonModel.TagListModel_SelectedItemsChanged() resets the search string to "Host:", removing extra criteria, search panel UI is updated
Need to investigate why 2) happens.
In CommonModel.BookmarkListModel_Navigated() method, getTagList().getResetCommand().Execute() causes TagListModel.Reset() -> TagListModel.SyncSearch(), which executes asynchronously after BookmarkListModel_Navigated() does its job. Therefore, TagListModel.Reset() causes the search string to be "resetted" to the default value for the given main tab, e.g. "Hosts:". CommonModel.TagListModel_SelectedItemsChanged() patched, needs review from Gilad. Pinning a tag must deselect tree selection, otherwise CommonModel.SplitSearchString() will calculate wrong search/prefix strings when unpinning a tag. In C# SystemTreeModel.ResetRequestedEvent is handled in a custom way, need to adapt that logic in webadmin. closing ON_QA bugs as oVirt 3.1 was released: http://www.ovirt.org/get-ovirt/ |