Bug 742882 (ghc-semigroups)

Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3401374

rpmlint is clean.

One comment though: I think you need to BR ghc-containers-prof
for F14 (and current F15 ghc too), otherwise it won't build there
(this can probably be waived one day when -prof is completely gone).

Ok, will  correct it and provide the new links here.

Thanks

Here is the review:

 +:ok, !: needs attention, NA: not applicable

MUST Items:
[+] MUST: rpmlint output [1]

rpmlint is clean

[+] MUST: package named according to Package Naming Guidelines
[+] MUST: spec file name must match base package %{name} [2]
[+] MUST: meet Packaging Guidelines
[+] MUST: Fedora approved license and Licensing Guidelines
BSD 3 clause
[+] MUST: License field in the package spec file must match actual license. [3]
[+] MUST: include license files in %doc if available in source [4]
[+] MUST: The spec file must be written in American English [5] and be legible. [6]
[+] MUST: source md5sum matches upstream release (from upstream URL)

b8ba7f9ff146b12a3940a862e2165936  semigroups-0.8.tar.gz

[+] MUST: successfully compile and build into binary rpms on a primary arch [7]

see comment 1

[NA] MUST: if necessary use ExcludeArch for other archs [8]
[!] MUST: All build dependencies must be listed in BuildRequires

Please add ghc-containers-prof (comment 1) for F14.

[NA] MUST: use %find_lang macro for .po translations [9]
[NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [10]
[+] MUST: Packages must NOT bundle copies of system libraries. [11]
[NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [12]
[+] MUST: A package must own all directories that it creates. [13]
[+] MUST: A package must not contain any duplicate files in the %files listing. [14]
[+] MUST: Permissions on files must be set properly. [15]
[+] MUST: consistently use macros [16]
[+] MUST: package must contain code, or permissable content. [17]
[NA] MUST: Large documentation files should go in a doc subpackage. [18]
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [18]
[+] MUST: Header files must be in a -devel package. [19]
[NA] MUST: Static libraries must be in a -static package. [20]
[NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19]
[+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [21]
[+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [20]
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [22]
[+] MUST: Packages must not own files or directories already owned by other packages. [23]
[+] MUST: All filenames in rpm packages must be valid UTF-8. [24]

SHOULD Items:
[+] SHOULD: If scriptlets are used, those scriptlets must be sane. [29]

Package is APPROVED.

but please attend to the missing BR and also please remove "Provides"
from the common_summary.

Thanks for the review.

>please attend to the missing BR and also please remove "Provides"
>from the common_summary.
Yes will take care of those while importing.

New Package SCM Request
=======================
Package Name: ghc-semigroups
Short Description: Types for Haskell 98 semigroups
Owners: narasim
Branches: f14 f15 f16
InitialCC: haskell-sig

Git done (by process-git-requests).

ghc-semigroups-0.8-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ghc-semigroups-0.8-1.fc15

ghc-semigroups-0.8-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ghc-semigroups-0.8-1.fc14

ghc-semigroups-0.8-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ghc-semigroups-0.8-1.fc16

ghc-semigroups-0.8-1.fc16 has been pushed to the Fedora 16 testing repository.

ghc-semigroups-0.8-1.fc14 has been pushed to the Fedora 14 stable repository.

ghc-semigroups-0.8-1.fc15 has been pushed to the Fedora 15 stable repository.

ghc-semigroups-0.8-1.fc16 has been pushed to the Fedora 16 stable repository.

We need semigroups to build conduit for EPEL6.


Package Change Request
======================
Package Name: ghc-semigroups
New Branches: el6
Owners: narasim petersen
InitialCC: haskell-sig

Git done (by process-git-requests).