| Summary: | Review Request: libpwquality - A library for password generation and password quality checking | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Mraz <tmraz> |
| Component: | Package Review | Assignee: | Miloslav Trmač <mitr> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mitr, notting, package-review |
| Target Milestone: | --- | Flags: | mitr:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-12 13:03:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Tomas Mraz
2011-10-03 14:31:55 UTC
rpmlint: > libpwquality.src: W: spelling-error %description -l en_US cracklib -> crack lib, crack-lib, crackling > libpwquality-devel.x86_64: W: spelling-error %description -l en_US pwquality -> quality > libpwquality.x86_64: W: spelling-error %description -l en_US cracklib -> crack lib, crack-lib, crackling false positives > libpwquality-devel.x86_64: W: no-documentation oh well... upstream issue > libpwquality.x86_64: W: no-manual-page-for-binary pwscore > libpwquality.x86_64: W: no-manual-page-for-binary pwmake upstream issue, however would be good to fix soonish Needs fixing: * Doesn't build in koji At least missing BuildRequires: pam-devel * Licensing problems/uncertainty: * License field says (BSD and GPLv2+) * Licensing guidelines require using "or" for dual licensing * Source files allow BSD or referenced GPL (note: not GPLv2, not GPL+!) * COPYING contains the same reference to GPL without v2/+, but includes text of GPLv2 * Source URL incorrect * Per "File and Directory Ownership" (gdm example), there should be > Requires: pam for {/etc,%_libdir}/security instead of relying on the automatic libpam dependency. Not sure: * I'm not quite happy about > ln -sf ../../%{_lib}/libpwquality.so.*.* libpwquality.so this only works for some values of %{_libdir}. Using an absolute symlink would be more general - OTOH this is not really a concern for Fedora * If you plan to maintain ChangeLog, please include it in %doc Notes: * Unnecessary > Requires(postun): /sbin/ldconfig - the -p interpreter is added automatically * BuildRoot: is unnecessary * %global is preferred over %define * Consider using (make install ... INSTALL='install -p') to preserve timestamps (In reply to comment #1) > > > libpwquality-devel.x86_64: W: no-documentation > oh well... upstream issue I plan to add some documentation in future. Currently the API is at least partially documented in the comments in the public header file. > > libpwquality.x86_64: W: no-manual-page-for-binary pwscore > > libpwquality.x86_64: W: no-manual-page-for-binary pwmake > upstream issue, however would be good to fix soonish Yeah, I plan to add the manpage soon. > Needs fixing: > * Doesn't build in koji > At least missing BuildRequires: pam-devel Fixed. Now I verified that it builds in mock. > * Licensing problems/uncertainty: > * License field says (BSD and GPLv2+) > * Licensing guidelines require using "or" for dual licensing > * Source files allow BSD or referenced GPL (note: not GPLv2, not GPL+!) > * COPYING contains the same reference to GPL without v2/+, but includes > text of GPLv2 Fixed to 'BSD or GPL+' which is correct according to the License guidelines. > * Source URL incorrect Fixed. > * Per "File and Directory Ownership" (gdm example), there should be > > Requires: pam > for {/etc,%_libdir}/security instead of relying on the automatic libpam > dependency. Fixed. > Not sure: > * I'm not quite happy about > > ln -sf ../../%{_lib}/libpwquality.so.*.* libpwquality.so > this only works for some values of %{_libdir}. Using an absolute symlink > would be more general - OTOH this is not really a concern for Fedora I do not think we care about hypotetical or third party distributions. This is Fedora packaging and if %{_libdir} changes significantly we will have to change the spec probably anyway. > * If you plan to maintain ChangeLog, please include it in %doc There is nothing meaningful in it yet. I plan to generate more meaningful changelog from upstream hg commits. > Notes: > * Unnecessary > > Requires(postun): /sbin/ldconfig > - the -p interpreter is added automatically Removed. > * BuildRoot: is unnecessary Removed. > * %global is preferred over %define Replaced. > * Consider using (make install ... INSTALL='install -p') to preserve timestamps Added. Spec URL: http://people.redhat.com/~tmraz/testing/libpwquality.spec SRPM URL: http://people.redhat.com/~tmraz/testing/libpwquality-0.9-2.fc17.src.rpm Thanks, accepted. New Package SCM Request ======================= Package Name: libpwquality Short Description: A library for password generation and password quality checking Owners: tmraz Branches: f16 InitialCC: Git done (by process-git-requests). Built in rawhide. In F16 it will be built later. Package Change Request ====================== Package Name: libpwquality New Branches: el5 el6 Owners: tmraz Git done (by process-git-requests). |